Skip to content

fix(core): Broaden Dependencies (CAN-408) - #186

Open
Saaketh0 wants to merge 7 commits into
mainfrom
CAN-408-Simplify-Dependencies
Open

Saaketh0 wants to merge 7 commits into
mainfrom
CAN-408-Simplify-Dependencies

Conversation

@Saaketh0

Copy link
Copy Markdown
Collaborator

When a workflow was launched and used a dependency that we also use (grpcio, redis, etc..), if the versions needed for our code and their code to run conflicted, errors happened.

Some of the dependencies we had could be simplified/removed. Instead of pinning the versions, I introduced a range of versions that we support, with a dependency below our range immediately erroring saying we don't support it and a dependency above our range giving a warning saying we haven't tested it.

I also simplified some of the code and removed some high level features like the nx in Redis to allow for our minimum Redis version to be lower and broader.

Added the requirements to the readme, and increased the size of the banner since I thought it looked weird.

@Saaketh0 Saaketh0 self-assigned this Sep 23, 2026
@Saaketh0 Saaketh0 added Non-Critical Fix Something that fixes something, but is not of utmost importance Core Pertaining to canyonos_core, the core systems in this repo labels Sep 23, 2026
@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1f07e915-7f46-4527-938b-a58196dfca1e


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread packages/core/canyonos_core/controller/local_controller.py Fixed
Comment thread packages/core/canyonos_core/controller/local_controller.py Fixed
Comment thread packages/core/canyonos_core/controller/local_controller.py Dismissed
Comment thread packages/core/canyonos_core/controller/local_controller.py Dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Pertaining to canyonos_core, the core systems in this repo Non-Critical Fix Something that fixes something, but is not of utmost importance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants