Skip to content

feat(cli): Resource Config Check at Deploy Time (CAN-409) - #184

Merged
Saaketh0 merged 8 commits into
mainfrom
CAN-409-Deploy-Resource-Config
Sep 24, 2026
Merged

Saaketh0 merged 8 commits into
mainfrom
CAN-409-Deploy-Resource-Config

Conversation

@Saaketh0

Copy link
Copy Markdown
Collaborator

Currently when deploying resources, users may want to change the agent resource requirements that each container that the agent is placed on uses.

This does that.

When you run canyonos deploy, it would show a screen that allows you to change these, where changing a resource value would change the corresponding value in global_controller.yaml.

@Saaketh0 Saaketh0 self-assigned this Sep 23, 2026
@Saaketh0 Saaketh0 added Enhancement New feature or request Non-Critical Fix Something that fixes something, but is not of utmost importance CLI Pertaining to canyonos CLI, mainly in the CLI folder labels Sep 23, 2026
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d26f9c23-51c3-42c9-87d8-8033a97c589c

📥 Commits

Reviewing files that changed from the base of the PR and between 6077246 and 09a80e2.

📒 Files selected for processing (5)
  • packages/cli/canyonos/deploy.py
  • packages/cli/canyonos/resources.py
  • packages/cli/tests/test_canyonos_deploy.py
  • packages/cli/tests/test_resources.py
  • packages/cli/utils/tui.py
 ____________________________________________________________________________________________________________________________________________________
< Critically analyze what you read and hear. Don't be swayed by vendors, media hype, or dogma. Analyze information in terms of you and your project. >
 ----------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Saaketh0 Saaketh0 changed the title Resource Config Check at Deploy Time Resource Config Check at Deploy Time (CAN-409) Sep 23, 2026
@Saaketh0 Saaketh0 changed the title Resource Config Check at Deploy Time (CAN-409) feat(cli): Resource Config Check at Deploy Time (CAN-409) Sep 23, 2026

@nickhuo nickhuo left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

it'll be good to add action instructions here, e.g. enter confirm; esc cancel

@Saaketh0

Copy link
Copy Markdown
Collaborator Author

@nickhuo Made a fix according to your comment

@Saaketh0
Saaketh0 requested a review from nickhuo September 24, 2026 00:07

nickhuo commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

thx, another quality improvement, it'd be good to have an msg show up when the type of the input is illegal instead of silently ignore the given input.

besides that, lgtm

Screen Recording 2026-09-23 at 17.11.04.mov

@Saaketh0

Copy link
Copy Markdown
Collaborator Author

@nickhuo Thanks for the suggestion, implemented it!

@Saaketh0
Saaketh0 enabled auto-merge (squash) September 24, 2026 00:32
@Saaketh0
Saaketh0 force-pushed the CAN-409-Deploy-Resource-Config branch from c0c8ad7 to 40bfd17 Compare September 24, 2026 05:27
@Saaketh0
Saaketh0 force-pushed the CAN-409-Deploy-Resource-Config branch from 40bfd17 to b76e766 Compare September 24, 2026 05:27
@Saaketh0
Saaketh0 disabled auto-merge September 24, 2026 05:28
@Saaketh0
Saaketh0 enabled auto-merge (squash) September 24, 2026 05:28
@Saaketh0

Copy link
Copy Markdown
Collaborator Author

@userAugustos This merge keeps getting blocked and I am not sure why, the build check is stalling out and when I press update branch it retries the build and then stalls out again

@userAugustos

Copy link
Copy Markdown

@Saaketh0 yes, just fixed this on #195

@Saaketh0
Saaketh0 merged commit 486d4b2 into main Sep 24, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI Pertaining to canyonos CLI, mainly in the CLI folder Enhancement New feature or request Non-Critical Fix Something that fixes something, but is not of utmost importance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants