feat(cli): Resource Config Check at Deploy Time (CAN-409) - #184
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@nickhuo Made a fix according to your comment |
|
thx, another quality improvement, it'd be good to have an msg show up when the type of the input is illegal instead of silently ignore the given input. besides that, lgtm |
|
@nickhuo Thanks for the suggestion, implemented it! |
c0c8ad7 to
40bfd17
Compare
40bfd17 to
b76e766
Compare
|
@userAugustos This merge keeps getting blocked and I am not sure why, the build check is stalling out and when I press update branch it retries the build and then stalls out again |
Currently when deploying resources, users may want to change the agent resource requirements that each container that the agent is placed on uses.
This does that.
When you run canyonos deploy, it would show a screen that allows you to change these, where changing a resource value would change the corresponding value in global_controller.yaml.