Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior
This PR is stacked on #170, which makes
starting,healthy, andfailedtrustworthy. It deliberately preserves the existing startup window rather than aborting on the first observedfailed: Redis can be reused between deploys, so an early read can see a previous run's status before the new controller publishes its own state.After the timeout, the Global Controller now performs a final read. If any configured replica is still not
healthy, it logsCRITICAL, raises, exits the in-container deploy process non-zero, and never reaches theGlobal controller startedmarker that causes the CLI to printDeploy is live.Verification
uvx --from uv==0.12.15 uv run --package canyonos-core pytest -q packages/core/tests— 268 passed, 1 skipped, 29 subtests passeduvx --from uv==0.12.15 uv run --package canyonos pytest -q packages/cli/tests— 156 passeduvx --from uv==0.12.15 uv run ruff check ...— passeduvx --from uv==0.12.15 uv run ruff format --check ...— passeduvx --from uv==0.12.15 uv run ty check— passedDepends on #170.