Align porting-to-canyonos skill naming with post-rename core - #83
Merged
Conversation
The skill's runtime contract docs and validation checks still referred to the pre-rename `ventis` package, `VENTIS_*` env vars, and `ventis-*` Docker resources. Since CAN-255 (17ad707) renamed these to `canyonos_core`, `CANYONOS_*`, and `canyonos-*` throughout canyonos_core/, the skill's capability probe (validation/runtime.py) was importing a module path that no longer exists, silently reporting every gated capability as unavailable. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
iidsample
approved these changes
Sep 9, 2026
nickhuo
added a commit
that referenced
this pull request
Sep 11, 2026
canyonos_core's runtime contract changes faster than the porting-to-canyonos skill's docs and validators track it (see 76b5a45, #83). Pin the skill's factual claims to executable assertions against real canyonos_core source instead of hand-maintained prose, and run them where they can actually block a PR: - tests/test_porting_skill_contract.py: behavior assertions for claims in manifest.md/runtime-contract.md, plus a coverage check that diffs every top-level config key canyonos_core reads off `self.config` against manifest.md's ownership table -- the same class of gap that let otel.destinations go undocumented. It found two more real gaps (project_id, cleanup_interval); those manifest.md rows are documented in #86 rather than here, since that's the PR already carrying this skill's doc fixes. - .github/workflows/ci.yml: actually run `pytest`. It never had before. - tests/conftest.py: compile the gRPC stubs global_controller.py imports at module load time, so importing it from a plain checkout doesn't require a prior `canyonos build`. This was blocking collection of 11 existing test files, which is almost certainly why pytest was never wired into CI. - tests/test_cli.py: three deploy tests globally monkeypatched `os.path.isfile` truthy, which also fooled resolve_env_file's unrelated platform-secrets check. Patch resolve_env_file directly instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove all the ventis to align #76