Conversation
…ly cryoscope.seq, cryoscope.system, and cryoscope.waveform had changes. These were biult on the cryoscope computer with wdl from commit: 949674d4f065e7aa88262d8fb27f85341fe2072c
scizen9
requested review from
astronomerdave,
jakezimmer,
mikelangmayr and
prkrtg
September 8, 2026 22:20
Author
|
I also note that the wdl file changed, so we should verify that this is the correct version. |
|
Why does every instrument have to carry every other instrument's code? and what looks like a submodule "wdl" to more non-cryoscope code |
Author
|
Not sure. It's good to have a general repo, but I agree that for a specific project, it makes sense to only checkout those files. I was assuming this would be purely for archival uses, not for operations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates from the embedded cryoscope computer to all wdl files, but only:
had changes.
These were built on the cryoscope computer with wdl at commit: 949674d4f065e7aa88262d8fb27f85341fe2072c