Add bulk keyword reads with capability detection, and test both transports - #31
Merged
Merged
Conversation
mikelangmayr
force-pushed
the
mike/keygrabber-transport-parametrized-tests
branch
from
September 16, 2026 00:32
1e019e2 to
c4055c3
Compare
prkrtg
approved these changes
Sep 16, 2026
mikelangmayr
deleted the
mike/keygrabber-transport-parametrized-tests
branch
September 16, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keys.read, a third auto-registered meta-service that reads many keywords in one request; per-keyword failures ride insidevaluesso one broken getter costs only itself, and pattern selection skips write-only keywordsservicesfield fromkeys.list, derived from the keys this peer actually serves minus its registered keywords, so a caller can tell "nokeys.readhere" from "no answer"; peers on an older libby omit it, which is the negative signalknows_keycannot answer that question: it reads the discovery registry, which stays empty becauseLibby.rabbitmqhardcodesdiscover=False, and probing by callingkeys.readis indistinguishable from a timeout since an unknown key is dropped without an ACKClient.listing,list,describeandread.listreturns qualified names that feed straight back intoget/show/read;listingreturns names and services from the one response;readissues one request per peer, never raises for a failed read, and chunks long name listslistanddescribeontoClient, replacing its private_rpc_keys_*helpers.show <pattern>deliberately keeps one show per match, so the CLI still works against daemons on a libby withoutkeys.readtests/test_client_integration.pyover ZMQ and RabbitMQ via shared base cases; the ZMQ cases need no external service and always run, the RabbitMQ ones keep their broker skipsleep(2.0)/sleep(1.5)warm-ups: both transports already block instart()until reachable, andtest_first_read_needs_no_warmupnow asserts that per transport so a barrier regression fails loudly instead of going flakyTestsworkflow, since CI built docs and never ran the suite. No broker service container, so the ZMQ cases are what guard the wirekeys.read, theservicesfield and the newClientmethods indocs/source/keywords.mdanddocs/source/client.mdkeys.readlibby:servicescomes back empty and the per-keyword fallback reads correctly. 71 tests pass, pylint 10.00/10 on the new modules