Rename address segments to <group>.<daemon>.<keyword> - #30
Merged
Merged
Conversation
mikelangmayr
commented
Sep 14, 2026
Collaborator
- "scope" was jargon that appears in no config file, and the parse error said "keyword must be ..", using "keyword" for the whole address and "name" for its last segment
- errors, help text, docstrings and the CLI/client docs now say ..; the middle segment is a daemon's peer_id and the last is what the system already calls a keyword
- local variables renamed to match, so the code reads the same as the messages; peer_id() and parse_keyword() are positional everywhere, so no caller changes
- trimmed qualified_peer_id's docstring, whose rationale belongs in the design doc
- verified the messages: "address must be .., got: hsfei" and "wildcards (%) are not allowed in or "; suite passes (30 tests, including the live-broker round trip)
prkrtg
approved these changes
Sep 14, 2026
prkrtg
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.