Skip to content

Make the consolidated isloopclosed writable - #205

Merged
mikelangmayr merged 1 commit into
mainfrom
mike/consolidated-isloopclosed-write
Sep 15, 2026
Merged

mikelangmayr merged 1 commit into
mainfrom
mike/consolidated-isloopclosed-write

Conversation

@mikelangmayr

Copy link
Copy Markdown
Contributor
  • on multi-stage modules (LSM, MS) the module-level isloopclosed was read-only, so libby modify hsfei.lsm.isloopclosed=true was rejected even though isreferenced accepts a write and piaa-gimbalmount already allows writing its module-level isloopclosed
  • it now sets the loop on every stage, mirroring _set_all_referenced
  • extracted _Stage.set_loop_closed from the inline lambda so the per-axis keyword and the consolidated one call the same code, matching how the getters were already factored
  • verified against a live broker with a mocked controller: the consolidated keyword reports readonly False, a write reaches close_loop on each stage with the right device and enable flag, and single-stage configs still register exactly one isloopclosed with its per-axis setter intact

@mikelangmayr
mikelangmayr merged commit 60f5b92 into main Sep 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants