Fix systemd instance files after the peer_id renames - #200
Merged
Merged
Conversation
mikelangmayr
commented
Sep 14, 2026
Contributor
- five instance files still pointed at configs deleted by the acronym rename (pickoff, rlight, msel, focpupsel, atcpickoff), so those units could never start; renamed to feipo, lsm, ms, atcl, atcp with their config paths updated
- added the ten instances that had no file at all: atcfw, piaagimb, piaagimr, hkettherm, yjettherm; coverage is now all 22 configs under config/hsfei and config/hscal
- WorkingDirectory moves from /opt/hispec/app to /var/log/hispec. The drivers write their own .log into the working directory, and the repo checkout is root-owned, so hsfei_atcpress died on startup with "Permission denied: /opt/hispec/app/inficonvgc502.log". /var/log/hispec is already created group-writable by install.sh
- README instance table regenerated from the instance files themselves, so the names cannot drift from reality again
- README now states the polkit rule needs polkit 0.106+ (Ubuntu 22.04 and later), since on an older host it is ignored silently and operators just get an auth prompt
- verified every instance resolves to an existing config and daemon script, and systemd-analyze verify passes on the unit
…king directory writable
prkrtg
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.