Skip to content

inficon reports a successful hardware connection after the connection times out #201

Description

@mikelangmayr

on_start logs "Daemon started successfully and connected to hardware" on the line immediately after the connection failed, because the driver swallows the error instead of raising, so the except branch never runs.

Seen on hispec-new:

15:27:40 ERROR - Connection error: Connection timed out
15:27:40 atcpress - INFO - Daemon started successfully and connected to hardware

isconnected correctly reports False, so the state is right and only the log lies, but it will mislead whoever reads the journal during an incident.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions