Document INTERFACE_TYPE as the emulator selector - #22
Merged
Merged
Conversation
mikelangmayr
requested review from
astronomerdave,
prkrtg and
scizen9
as code owners
September 15, 2026 22:05
prkrtg
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-DINTERFACE_TYPE=AstroCamis "not an option this project defines", and that the emulator "is built only for-DCONTROLLER=archon"INTERFACE_TYPEis defined, in the top-level CMakeLists, defaulting toArchonwhen not set, and it is what the emulator's CMakeLists branches onCONTROLLER: verified that-DCONTROLLER=archon -DINTERFACE_TYPE=AstroCamreports "emulator not implemented for AstroCam" and produces no emulator target, so the emulator followsINTERFACE_TYPEand not the controllerINTERFACE_TYPEdoes not select the controller, not because it does not exist