Repository navigation
Firefly-2148: Clean up some hips issues - #2053
Merged
Merged
Conversation
kpuriIpac
approved these changes
Oct 29, 2026
kpuriIpac
left a comment
kpuriIpac
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Testing worked as described.
- hips/fits extraction seem to need to be turned off and on to pivot between the two - support HiPS property: hips_pixel_function - better handle one of the hips list severs being down - added some test - response to review: added connection timeout
robyww
force-pushed
the
FIREFLY-2148-hips-cleanup
branch
from
October 29, 2026 19:20
b668d6a to
50271bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIREFLY-2148: Clean up some hips issues
Testing
hips_pixel_functionupdate is too hard to test