fix: bound countersink cuts by explicit depth - #2103
Open
RanaPriyansh wants to merge 1 commit into
Open
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2103 +/- ##
==========================================
+ Coverage 95.80% 95.81% +0.01%
==========================================
Files 30 30
Lines 9589 9592 +3
Branches 1439 1440 +1
==========================================
+ Hits 9187 9191 +4
Misses 247 247
+ Partials 155 154 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1653.
cskHolecan cut below an explicit shallow depth because its countersink cone extends to its full tip.Clip the cone to the requested depth before combining it with the bore. The full cone remains in use for deeper and through holes.
Tests
test_interpPlatevolume mismatch occurs on the exact base.A small local timing comparison measured shallow cuts at 6.7–6.9 ms before and 8.0 ms after this change. Deep and through-hole timings overlapped. The shallow path performs one additional Boolean intersection.
Codex used.