Repository navigation
fix(milkdrop): a still motion-vector stub points up, as in MilkDrop - #751
Merged
Merged
Conversation
…560) When a vector has no length at all (for example `mv_l = 0`, or a still field), MilkDrop draws a one-texel stub with `dx = dy = min_len` (milkdropfs.cpp, DrawMotionVectors). Its `fy` runs bottom-up, so the stub goes right and UP. Our grid runs top-down and kept the same sign, so the stub went right and down. Vectors with a real length were already right. Found while checking the motion-vector code against MilkDrop's for #750. Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
|
CaYaDraft — pull request Summary Files
Note Stopping here. I will not merge, push, or change this pull request until you ask.
|
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a motion vector has no length at all (
mv_l = 0, or nothing moves), MilkDrop draws a one-texel stub withdx = dy = min_len. MilkDrop'sfyruns bottom-up, so the stub goes right and up; ours runs top-down and kept the sign, so it went right and down. Vectors with a real length were already correct.src/visualizer/modes/milkdrop.js:ddy = -minLenin the zero-length branch.tests/milkdrop-motion-vectors.test.js: a still field (mv_l = 0) draws stubs one texel right and one texel up. Fails without the fix (yukarı: 0.00104 / -0.00104).Found while checking our motion-vector code against MilkDrop's for #750.
Refs #560, #695