Conversation
Like IPv6 addresses. Move to using these trivial types internally.
rmn30
reviewed
Sep 9, 2026
Comment on lines
+691
to
+693
| IPv4Address IPv4Header::*remoteAddress, | ||
| uint16_t TCPUDPCommonPrefix::*localPort, | ||
| uint16_t TCPUDPCommonPrefix::*remotePort, |
Contributor
There was a problem hiding this comment.
Should we have a type for port numbers too? What is going on with the namespace prefixes here?!
Member
Author
There was a problem hiding this comment.
Those are pointers to data members.
I'm generally in favor of more types...
davidchisnall
approved these changes
Sep 9, 2026
| /** | ||
| * The bytes of the address. | ||
| */ | ||
| uint8_t bytes[16]; |
Contributor
There was a problem hiding this comment.
It's a bit inconsistent to use a C array here and a std::array for MAC addresses?
Member
Author
There was a problem hiding this comment.
I was wondering. Happy to make consistent in either direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is that these become pervasive, if they're useful.