Instruction updates with insert and remove, mission revision and status details - #305
Draft
jp-pino wants to merge 1 commit into
Draft
Instruction updates with insert and remove, mission revision and status details#305jp-pino wants to merge 1 commit into
jp-pino wants to merge 1 commit into
Conversation
jp-pino
force-pushed
the
jp-pino/mission-updates
branch
2 times, most recently
from
September 9, 2026 20:28
bf23a8e to
be63483
Compare
…s and pause_on_completion Instruction.auto_continue (never set by clients, so proto3's default would have paused after every instruction) becomes pause_on_completion with the same number and type, so old missions keep running throughout. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
jp-pino
force-pushed
the
jp-pino/mission-updates
branch
from
September 9, 2026 20:33
be63483 to
fa9f3c3
Compare
jp-pino
added this pull request to stack #304
September 9, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetInstructionUpdateReqis not used by any client yet, so it is redesigned to cover replace, insert and remove, with a real answer:Also:
Mission.revision, increased by the drone with every accepted update.MissionStatus.active_instruction_id,revision,failure_reason.Instruction.auto_continuerenamed topause_on_completion(same number and type): the field was never set by clients, so with proto3's default the old meaning would have paused after every instruction. True now pauses after the instruction; old missions keep running throughout.NOTIFICATION_TYPE_MISSION_PAUSED_BY_INSTRUCTION(36) andNOTIFICATION_TYPE_MISSION_UPDATED(37).Depends on #303.