Skip to content

Instruction updates with insert and remove, mission revision and status details - #305

Draft
jp-pino wants to merge 1 commit into
jp-pino/motion-instruction-commandsfrom
jp-pino/mission-updates
Draft

Instruction updates with insert and remove, mission revision and status details#305
jp-pino wants to merge 1 commit into
jp-pino/motion-instruction-commandsfrom
jp-pino/mission-updates

Conversation

@jp-pino

@jp-pino jp-pino commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

SetInstructionUpdateReq is not used by any client yet, so it is redesigned to cover replace, insert and remove, with a real answer:

message SetInstructionUpdateReq {
  oneof operation {
    Instruction replace = 1;       // same field number and type as before
    InsertInstruction insert = 2;  // { instruction, before_id (0 appends) }
    uint32 remove_id = 3;
  }
}
message SetInstructionUpdateRep { bool accepted = 1; string reason = 2; uint32 revision = 3; }

Also:

  • Mission.revision, increased by the drone with every accepted update.
  • MissionStatus.active_instruction_id, revision, failure_reason.
  • Instruction.auto_continue renamed to pause_on_completion (same number and type): the field was never set by clients, so with proto3's default the old meaning would have paused after every instruction. True now pauses after the instruction; old missions keep running throughout.
  • NOTIFICATION_TYPE_MISSION_PAUSED_BY_INSTRUCTION (36) and NOTIFICATION_TYPE_MISSION_UPDATED (37).

Depends on #303.

@jp-pino jp-pino self-assigned this Sep 9, 2026
@jp-pino
jp-pino force-pushed the jp-pino/mission-updates branch 2 times, most recently from bf23a8e to be63483 Compare September 9, 2026 20:28
…s and pause_on_completion

Instruction.auto_continue (never set by clients, so proto3's default would
have paused after every instruction) becomes pause_on_completion with the
same number and type, so old missions keep running throughout.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant