Feat/add u256 - #30
Merged
Merged
Conversation
refactored normalize_to_threshold to calculate_normalizer_base_64; made algorithm_d function private
added tests for u256
LesterEvSe
requested changes
Aug 6, 2026
LesterEvSe
left a comment
LesterEvSe
left a comment
Collaborator
There was a problem hiding this comment.
We also have the eq_128 function, but I couldn't find eq_256. So it would be better to add it as well
Collaborator
|
The
|
LesterEvSe
reviewed
Aug 6, 2026
Collaborator
Author
We have a jet for |
LesterEvSe
self-requested a review
August 10, 2026 11:38
LesterEvSe
requested changes
Aug 10, 2026
LesterEvSe
approved these changes
Aug 11, 2026
LesterEvSe
left a comment
LesterEvSe
left a comment
Collaborator
There was a problem hiding this comment.
ACK 7ae47db; tested locally with simplex test --test-threads 8
Arvolear
added a commit
that referenced
this pull request
Aug 24, 2026
* Convert functions for u8 (#34) * added convert functions for u8 * commented out eq_256 (will be available with pr#30) * added split and safe_convert functions * refactored widening functions * linting * refactored u8 functions * typo * removed unused import * Convert functions for u1 (#35) * added assert_eq_bool * added convert functions for u1 * Convert functions for u16 (#36) * added convert functions for u16 * typo * added convert functions for u32 (#37) * Feat/add u256 (#30) * added full_add_128; refactored normalize_to_threshold to calculate_normalizer_base_64; made algorithm_d function private * added functions for uint256 * added U256Wrapper for u256 tests; added tests for u256 * fixed typo * splitted u256 arithmetic tests into two batches for faster tests * refactored split_256_into_64 * added full_sub_128 * linting * splitted u256 arithmetic tests into more batches * typo * removed unnecessary eq_256 * linting * review fixes: typos, helper optimization * renamed arithmetic tests files into more specific ones * linting for consistency * refactoring and typos * added missing check for division algorithm * added mul_128_64, mul_256_64 and mul_256_128 for optimization * doc fixes and small refactoring * Сonvert functions for u64 (#41) * added convert functions for u64 * typo * returned u32 typo back, it will be fixed in upcoming pr; renamed to -> into for u64 * added missing split_u64_into_u8 * fixed typo: `split to` -> `split into` (#43) * Convert functions for u128 (#42) * moved u128 to math file * added convert functions for u128 * typo * fixed typo * added missing split_u128 functions * resolved todo; utilized assert_eq in tests * fixed path * splitted math file into comparison and bit * renamed arithmetic test to basic math test for avoid ambiguity * Convert functions for u256 (#47) * added convert functions for u256; splitted u256_math into bit and comparison * updated readme * bumped simplex version * Update README * Bump Simplex version (#49) * quick reame fix --------- Co-authored-by: Yuliia Aritkulova <94910987+aritkulova@users.noreply.github.com> Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.