Repository navigation
gui: Drop edit hints from card entry - #213
Draft
BenWestgate wants to merge 1 commit into
Draft
BenWestgate wants to merge 1 commit into
BenWestgate wants to merge 1 commit into
Conversation
Recovery input gets no hint about what a wrong character should be, as in the CLI. Stop naming B, I, O and 1 with their look-alikes, stop telling the operator which header character to type, and stop marking the groups a suggested repair changed, so the whole card is compared. A header the library rejects reports the library's own message. Check a joining card with the field's header rule instead of a second copy of the backup and split checks. GUI: 1,986 -> 1,918 lines. Claude-Session: https://claude.ai/code/session_018HrKoywz6PT9c91jvKou7Q
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: typing B, I, O or 1 named the character and its likely look-alike ("B is probably 8"). Header mistakes came with edit instructions ("Change the last letter to S"). A suggested repair highlighted the groups it changed.
After: recovery input gets no hint about what a wrong character should be, as in the CLI. A character no card can contain is dropped from the field. A header the library rejects shows the library's own message. A suggested repair marks no group, so the whole card is compared against the paper.
A card joining the ones already entered is checked with the field's own header rule instead of a second copy of the backup and split checks.
How: remove
lookalike_fault, the header edit hints,_guessedand its CSS, and_incompatible. Update the tests, the walkthrough and the GUI docs. GUI: 1,986 → 1,918 lines, toward holding the 2,000 budget with #118 and #109 stacked on top.Validation: 967 tests pass normally and 967 under
python -O. Ruff and mypy pass. The GUI walkthrough passes. Recovery input changed, so this needs a security review before it is marked ready.Generated by Claude Code