Repository navigation
test: Replace brittle CLI help snapshots - #212
Merged
Merged
Conversation
Replace full top-level and wallet help snapshots with targeted checks for command availability, safe input guidance, options, and successful --help exits. Keep the actionable argument-error assertion, which covers behavior rather than documentation wording. Focused generic-HRP tests: 8 passed. Ruff check and format, and git diff --check: passed. Refs #195
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ms32 --helptest pinned every line of CLI copy, so harmless wording and line wrapping edits forced unrelated test updates.This PR replaces the top-level and wallet help snapshots, plus the wrapped
correct,secret, andsharedescriptions, with checks for:--helpexit, usage output, and no stderr.codex32versusms32.--bytes,--account, and--timestampoptions and wallet rescan guidance.The exact
shareargument-error assertion remains because it verifies actionable CLI error behavior. No runtime code changes.Validation: 8 tests in
tests/test_generic_hrp.pypassed; Ruff lint/format andgit diff --checkpassed.Closes #195.