Repository navigation
feat(deps): declare brand as an optional peer dependency - #2
Merged
Merged
Conversation
ui already reads brand's CSS variables; declaring the peer makes that coupling explicit and lets the app own the brand version. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uialready readsbrand's CSS variables but never declared it. This declares@behindthemusictree/brandas an optional peer dependency (^12.0.0), so the app owns the brand version and a mismatch surfaces as a peer warning instead of duplicate tokens at runtime.Changes
packages/ui/package.json:brandadded topeerDependencies(optional viapeerDependenciesMeta) and todevDependenciesfor local buildsREADME.md: lists the eight CSS variablesuireads, so non-BTMT consumers can supply their own instead of installingbrandCHANGELOG.md: Unreleased entry; intended release is minor (0.2.0)Test plan
pnpm install && pnpm lint && pnpm buildpass locallyvar(--…)usages inpackages/ui/src