Snt25 659 outliers (IQR) - #119
Merged
Merged
Conversation
Collaborator
Author
|
@sPuntinG I resolved the merge conflicts, this branch is ready to be Squash and merged. |
sPuntinG
approved these changes
Sep 15, 2026
sPuntinG
left a comment
Contributor
There was a problem hiding this comment.
Ok cool, all seems good!
I re-run the notebooks in the SNT Testing ws (BFA data) with all modified files (copied the whole ./code folder and the whole ./snt_dhis2_outliers_imputation_iqr folder in the ws).
Then also run via pipeline (latest version from template, without the "Pull scripts").
This seems enough of a test since the changes are all in the nb setup, utils and engeneering side -- no changes to core calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third cleaning (no functional changes) --> only a fix for imputation function printing infinite warnings.
Scripts touched:
snt_dhis2_outliers_imputation_iqr.ipynb
Report:
snt_dhis2_outliers_imputation_iqr_report.ipynb
.R files touched:
snt_utils.r --> (small fixes and added a new path in snt_init function to "figures" folder to be available during reporting)
snt_dhis2_outliers_imputation_iqr.r
snt_dhis2_outliers_imputation_iqr_report.r
Re-arranged try: block in the python pipeline snt_dhis2_outliers_imputation_iqr (no functional changes)