Repository navigation
Backport JCA TLS trust validation fix for 2.12.1 - #50744
Merged
ROHIT SINGHAL (rohitsinghal4u) merged 6 commits intoOct 19, 2026
Conversation
(cherry picked from commit 314db42) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 4 pipeline(s). 30 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ROHIT SINGHAL (rohitsinghal4u)
marked this pull request as ready for review
October 16, 2026 23:48
ROHIT SINGHAL (rohitsinghal4u)
requested review from
a team,
Jonathan Giles (JonathanGiles),
Jair Myree (jairmyree),
Moary Chen (moarychan),
Sameeksha Vaity (samvaity) and
Xiaolu Dai (saragluna)
as code owners
October 16, 2026 23:48
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ROHIT SINGHAL (rohitsinghal4u)
requested a review
from Alan Zimmer (alzimmermsft)
as a code owner
October 17, 2026 05:38
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ROHIT SINGHAL (rohitsinghal4u)
requested a review
from vcolin7
as a code owner
October 19, 2026 00:18
ROHIT SINGHAL (rohitsinghal4u)
merged commit Oct 19, 2026
e5f7222
into
Azure:hotfix/azure-security-keyvault
62 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports #50667 (314db42) for the stable azure-security-keyvault-jca 2.12.1 hotfix.
The target branch, hotfix/azure-security-keyvault, starts at the actual 2.12.0 release commit, 6b905e9 (#49921). Its JCA sources match the published 2.12.0 sources after accounting for declared dependency shading. No later beta feature changes are included.
The trust-manager implementation and all 161 regression cases are unchanged from the merged fix. The only cherry-pick conflict was the changelog; this PR adds only the TLS fix under 2.12.1 (2026-10-17), preserving prior published release history. The changelog links to this hotfix PR.
Updates the JCA patch version in version_client.txt, the module POM, README, and JCA test-harness dependency using the repository version-sync script. Synchronizes four existing JCA dependency references in the two Spring consumer POMs and the OpenRewrite POM to the published 2.12.0 dependency version, as required by the repository-wide version map. The JCA hotfix version remains 2.12.1. Other Key Vault libraries and JCA's runtime dependency versions are unchanged.
The current CI images use Maven 3.10 with Java 25. Compiler plugin 3.14.0's module-info transformer loads ASM 9.7.1, which rejects Java 25 class files. The shared azure-sdk-parent and independent clientcore-parent pin the compiler's build-only ASM dependency to the existing version-map value 9.9.1. This repairs compilation across the affected client, performance, and Spring source-build paths without changing runtime dependencies, bytecode compatibility targets, or validation gates.
Includes the existing upstream test-only ProxyOptionsTests isolation fix: explicitly set absent NO_PROXY and the higher-priority HTTPS_PROXY values in HTTP test configurations, rather than inheriting the Windows build agent's proxy environment. Test expectations and production proxy behavior are unchanged.
Validation
Unsupported class file major version 69on unmodified hotfix code using Maven 3.10.0 and Temurin 25.0.4.1; the same azure-xml compile succeeds with the compiler-only ASM override.Contribution checklist
This PR prepares the hotfix only. The changelog date does not publish the package; package publication remains a separate step. For the manual shared Key Vault release pipeline, select JCA only and deselect the other libraries.