Repository navigation
[Storage] STG105 Files GET APIs by File ID - #50629
Open
browndav-msft wants to merge 39 commits into
Open
browndav-msft wants to merge 39 commits into
browndav-msft wants to merge 39 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 34 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
browndav-msft
changed the base branch from
main
to
feature/storage/stg105base
September 29, 2026 22:21
…rides Extend the Files-by-ID response timestamp directive to Get Hard Links and regenerate its headers. ISO-8601 SMB creation, last-write, and change timestamps cannot be parsed by the RFC 1123 deserializer selected by the shared Swagger. Research: the pre-existing Java swagger/README.md already overrides these response headers to date-time for directory create/get/set/rename and file create/get/download/set/rename/link operations. Generated FilesGetPropertiesHeaders and DirectoriesCreateHeaders use OffsetDateTime.parse, as does the hand-written FileSmbProperties header mapping. Python's azure-storage-file-share/swagger/README.md instead overrides all three response headers to strings to preserve timestamp precision. Keep the shared Microsoft.FileStorage/stable/2027-03-07/file.json unchanged: SDKs already apply language-specific handling, and changing existing shared definitions would broaden this feature's compatibility impact. Scope the new Java directives to file/directory properties by ID and Get Hard Links. Preserve previous operations and the RFC 1123 handling of HTTP Date, Last-Modified, and copy-completion timestamps. Generated Java was produced by AutoRest, not manually edited. The local Files-by-ID mock regressions cover fractional-second timestamps and sync/async file and directory property calls. The hard-link cases exposed the same parser mismatch and now pass with the regenerated model.
Replace the hand-written FileIdOperations REST client with generated operations in both synchronous and asynchronous clients. Centralize file-ID validation and addressing-mode guards in ShareErrors. Reuse property response mapping across path- and ID-addressed requests while preserving existing path-based behavior. Add regression coverage for timestamp and metadata mapping, service errors, and addressing-mode restrictions.
…nts for getproperties
Isabelle (ibrandes)
changed the title
Isabelle (ibrandes)
marked this pull request as ready for review
October 6, 2026 20:34
browndav-msft
force-pushed
the
stg105/files-by-id
branch
from
October 9, 2026 16:27
48864e0 to
44dea7e
Compare
…/azure-sdk-for-java into stg105/files-by-id
…)" This reverts commit 83dc6e2.
… stg105/files-by-id # Conflicts: # sdk/storage/azure-storage-file-share/swagger/README.md
Member
Author
|
/azp run java - storage - tests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - storage - tests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Comment on lines
+239
to
+242
| ShareFileAsyncClient asyncClient = new ShareFileAsyncClient(azureFileStorageClient, shareName, "", fileId, | ||
| snapshot, accountName, serviceVersion, sasToken); | ||
| return new ShareFileClient(asyncClient, azureFileStorageClient, shareName, "", fileId, snapshot, accountName, | ||
| serviceVersion, sasToken); |
| ``` yaml | ||
| use: '@autorest/java@4.1.63' | ||
| input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/15d7f54a5389d5906ffb4e56bb2f38fe5525c0d3/specification/storage/data-plane/Microsoft.FileStorage/stable/2026-06-06/file.json | ||
| input-file: C:\repos\azure-rest-api-specs\specification\storage\data-plane\Microsoft.FileStorage\stable\2027-03-07\file.json |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.