Skip to content

Bump @types/vscode from 1.136.0 to 1.137.0 - #2790

Open
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/types/vscode-1.137.0
Open

dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/types/vscode-1.137.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 14, 2026

Copy link
Copy Markdown
Contributor

Bumps @types/vscode from 1.136.0 to 1.137.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) from 1.136.0 to 1.137.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode)

---
updated-dependencies:
- dependency-name: "@types/vscode"
  dependency-version: 1.137.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 14, 2026
Copilot AI lite review requested due to automatic review settings September 14, 2026 18:33
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jainakanksha-msft

Copy link
Copy Markdown
Member

Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:

  1. Impact analysis — review the PR diff/description to identify what changed, including the package name and old → new version, then check where that dependency is actually used in the codebase, or whether it is unused, and summarize the potential impact.
  2. Fix build/conflict issues — run npm ci --legacy-peer-deps, npm run build, and npm run lint; resolve any merge conflicts, build errors, or lint errors that surface.
  3. Tests — add or update tests under tests/** to cover the changed usage, and make sure they meaningfully validate the change (not just re-assert the version bump).
  4. Run the suite — run the relevant npm run test:* script(s) for the affected area (e.g. test:blob, test:queue, test:table) and keep fixing until they pass.
  5. Changelog — append one bullet to ChangeLog.md under ## Upcoming ReleaseGeneral:, matching the existing style and tone of the entries already there (package name in backticks, old → new version, why, and a one-line concise summary of any code changes made).
  6. Comments — review any existing PR comments and review threads, including resolved/hidden ones, and address anything actionable.
  7. Self-rate — rate this work 1-10 against: correctness, test coverage, changelog accuracy, build/lint health, and comment resolution.
  8. Iterate — if it's not a 10, keep improving until it is before finishing.
  9. Summary — your final response must use the following structure exactly (no free-form paragraph summary).

Impact analysis

  • Package:
  • Old version:
  • New version:
  • Change Impact:

Build/Conflict Issues

  • Commands:
  • Result:

Tests

  • Added:
  • Updated:
  • Result:

Run the Suite

  • Commands:
  • Status:

Changelog

  • Entry:
  • Location:

Comments

  • Reviewed:
  • Actions:

Self-Rate

  • Score:
  • Reasoning:

Summary

  • Why this matters:
  • Risk of not taking change:

Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 14, 2026 18:41
@dependabot
dependabot Bot removed the request for review from Copilot September 14, 2026 18:41

Copilot AI commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:

  1. Impact analysis — review the PR diff/description to identify what changed, i...

Impact analysis

  • Package: @types/vscode (development-only type declarations)
  • Old version: 1.136.0
  • New version: 1.137.0
  • Change Impact: Used by src/extension.ts and VS Code adapters under src/common; upstream declarations differ only in their API-version header, so risk is limited to compile-time extension compatibility with no runtime/API behavior change.

Build/Conflict Issues

  • Commands: npm ci --legacy-peer-deps, npm run build, npm run lint
  • Result: All passed; no merge conflicts or source changes were required.

Tests

  • Added: None; a version-only assertion would not meaningfully test Azurite behavior.
  • Updated: None; existing tests/common/vscStatusBarItem.test.ts already compiles a concrete StatusBarItem implementation against the installed declarations and validates status transitions.
  • Result: All 4 affected VS Code status-bar tests passed.

Run the Suite

  • Commands: npm run test:exe, npm run build:exe, npm test
  • Status: npm test passed (899 passing, 4 pending). test:exe passed all 26 runnable common tests but its unrelated executable hook requires a Windows binary; build:exe correctly reports that Windows binaries cannot be built on Linux. Prior completed CI jobs have no failures; post-push jobs await GitHub approval (action_required, zero jobs).

Changelog

  • Entry: Added the 1.136.0 → 1.137.0 @types/vscode update and noted that validation required no source changes.
  • Location: ChangeLog.md, ## Upcoming ReleaseGeneral: (commit f76cc1b).

Comments

  • Reviewed: General PR comments, review submissions, and all review threads, including resolved/hidden threads (none present).
  • Actions: Addressed the only actionable comment; the earlier automated reviewer message required no action.

Self-Rate

  • Score: 10/10
  • Reasoning: Correct impact was verified against the upstream declaration diff and repository usage; install/build/lint/full tests pass, existing meaningful coverage was retained, changelog is accurate, comments are resolved, and review/security validation found no issues.

Summary

  • Why this matters: Keeps Azurite’s VS Code extension development typings current while confirming compatibility across the extension and common adapters.
  • Risk of not taking change: Azurite would remain on stale VS Code declarations and could miss future compile-time API compatibility issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants