test: add demo video regression coverage - #71
Ayush-Kumar0207 merged 2 commits into
Conversation
|
@kimberlydemaio is attempting to deploy a commit to the ayush-kumar0207's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi Kimberly — thank you for picking this up, and sorry I left your first contribution waiting for a week. I’ve reviewed the test, and it’s exactly the focused regression coverage this issue needed: it protects the video source, poster, optional captions behavior, and interactive demo link without changing production code. I’ve approved the first-time-contributor workflows now and I’m watching the checks. If they stay green, I’ll get this merged promptly. I also appreciate how clearly you documented the change and verification — this is a strong first contribution to CodeVerse. |
Ayush-Kumar0207
left a comment
There was a problem hiding this comment.
Approved — this is focused, well documented, and covers every acceptance criterion from #68. Thank you for keeping it test-only and following the existing testing conventions.
|
Merged — all refreshed CI, container, and CodeQL checks passed. Thank you again, Kimberly. This was a careful and genuinely useful first contribution, and you’d be very welcome to contribute again whenever another issue interests you. |
Why this change?
Issue #68 requests a regression test for the
/demo-videopage so future changes don't accidentally break the video, captions, poster, or demo link.Closes #68
What changed?
Added a new unit test for the
/demo-videopage./media/codeverse-demo.mp4/media/codeverse-demo-poster.jpg/media/codeverse-demo.vttdefault/demoworkspaceNo production code was changed.
How did you verify it?
npm run lintnpm run typechecknpm run audit:repoRan
npx vitest run tests/unit/demo-video.test.tsxAll 6 tests passed.
Risk, rollout, and recovery
Low risk. This is a test-only change, so it shouldn't affect the application.
If needed, it can be reverted by removing the new test file.
Reviewer guide
Please review:
client/tests/unit/demo-video.test.tsx