Skip to content

test: add demo video regression coverage - #71

Merged
Ayush-Kumar0207 merged 2 commits into
Ayush-Kumar0207:mainfrom
kimberlydemaio:test/demo-video-regression
Aug 31, 2026
Merged

Ayush-Kumar0207 merged 2 commits into
Ayush-Kumar0207:mainfrom
kimberlydemaio:test/demo-video-regression

Conversation

@kimberlydemaio

Copy link
Copy Markdown
Contributor

Why this change?

Issue #68 requests a regression test for the /demo-video page so future changes don't accidentally break the video, captions, poster, or demo link.

Closes #68

What changed?

Added a new unit test for the /demo-video page.

  • an HTML5 video element is rendered
  • the video source points to /media/codeverse-demo.mp4
  • the poster references /media/codeverse-demo-poster.jpg
  • an English captions track points to /media/codeverse-demo.vtt
  • the captions track is not marked as default
  • the page includes a link to the interactive /demo workspace

No production code was changed.

How did you verify it?

  • Relevant unit or server tests
  • npm run lint
  • npm run typecheck
  • npm run audit:repo
  • Relevant application or catalog audits
  • Production build when the client changed
  • Screenshots or recording for visible UI changes

Ran npx vitest run tests/unit/demo-video.test.tsx

All 6 tests passed.

Risk, rollout, and recovery

Low risk. This is a test-only change, so it shouldn't affect the application.

If needed, it can be reverted by removing the new test file.

Reviewer guide

Please review:

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

@kimberlydemaio is attempting to deploy a commit to the ayush-kumar0207's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Owner

Hi Kimberly — thank you for picking this up, and sorry I left your first contribution waiting for a week. I’ve reviewed the test, and it’s exactly the focused regression coverage this issue needed: it protects the video source, poster, optional captions behavior, and interactive demo link without changing production code.

I’ve approved the first-time-contributor workflows now and I’m watching the checks. If they stay green, I’ll get this merged promptly. I also appreciate how clearly you documented the change and verification — this is a strong first contribution to CodeVerse.

@Ayush-Kumar0207 Ayush-Kumar0207 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — this is focused, well documented, and covers every acceptance criterion from #68. Thank you for keeping it test-only and following the existing testing conventions.

@Ayush-Kumar0207
Ayush-Kumar0207 merged commit 95633d1 into Ayush-Kumar0207:main Aug 31, 2026
10 of 11 checks passed

Copy link
Copy Markdown
Owner

Merged — all refreshed CI, container, and CodeQL checks passed. Thank you again, Kimberly. This was a careful and genuinely useful first contribution, and you’d be very welcome to contribute again whenever another issue interests you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[First PR] Add a regression test for the narrated demo player

2 participants