Repository navigation
feat(panel): change hotkeys from the panel, and show when one is taken - #34
Merged
Merged
Conversation
* new TECLAS / KEYS tab: one row per hotkey; arrows or the list move it to any letter or digit under its modifiers, never one another action holds * applied at once: Hotkeys::rebind releases the old set and registers the new one, no restart; on GNOME the desktop shortcuts are reinstalled * a combination another program has is marked "(in use)" in its row and in the list, and said in a toast at startup and when picked * the warrior's tips, the lesson footers and the shortcut sheet show the new keys right away Refs #31 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #32 (base
release/v0.1.7).Why
A hotkey another program already owns silently did nothing. On Windows, NVIDIA's overlay holds Ctrl+Alt+M (the practice key): snowlearner logged
Hotkey unavailableto a file nobody reads, and every hint on screen kept saying "press Ctrl+Alt+M". The only fix was editingconfig.tomlby hand and restarting.What
Ctrl+Altby default; modifiers written inconfig.tomlare kept). A key another snowlearner action holds is never offered.Hotkeys::rebindreleases the old set and registers the new one, no restart. Where the desktop owns the shortcuts (GNOME on Wayland), they are reinstalled; on other Wayland desktops a toast says to runsnowlearner setup.(in use)in its row and in the list, said in a toast when picked, and said at startup instead of the welcome.lang/text.rs, pt-BR and English. No new dependency.Not in this PR: capturing an arbitrary combination by pressing it. The rows pick the key; other modifiers still come from
config.toml.Tests
rebindto U, another manager could take Y and could not take U.cargo fmt --check,cargo clippy --all-targets -- -D warnings(default features and--no-default-features) clean.cargo teston Windows: 513 lib + 26 CLI pass.Two lib tests fail on Windows only, both unrelated and failing without this PR's code paths:
command_engine_passes_text_on_stdin_when_not_in_the_template(callstee) and, intermittently,a_foreign_program_on_the_port_is_detected(its fake server closes the socket before the client reads; passes when run alone).Not verified: clicking through the tab in the running app, the GNOME reinstall path, macOS.
Closes #31
🤖 Generated with Claude Code