Skip to content

Minimal deliverables, overriding default values & settings #144

Description

@Av3boy

The codebase currently has things like default shaders and images. We should come up with a way on how we want to handle those in the future.

To actually deliver a NuGet package with as much content stripped away as possible, so that the user can download only the things that they need, those default things may be redundant.

If we move the defaults into a separate NuGet package, we will get build errors saying those shader variable names are missing.

We need to come up with which of these is the best solution:

  • Let the user set those default textures.
  • Immediately upon object creation specify the texture of an object.
  • Make the engine throw an exception about missing files.

We could leverage the Dependency Injection system to set a IDefaults interface with these values?

Similarly, we need to populate the ISettings interface.
Currently we have default settings which our windows use.

We also need to extend the window creation DI service so that the user is able to pass those settings as a Func.


When building our NuGet packages, things like loggers we might want to strip away.
To achieve that we might want to consider adding a compiler directive like #If LoggerEnabled and initialize that directive inside the .csproj by checking if the SharpEngine.Telemetry and Microsoft.Logging.Extensions libraries are present.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    coreThe issue is related to the Core library.enhancementNew feature or requestmaintainabilityspikeSomething that needs investigation / needs an answer

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions