Skip to content

docs(wiki): say npm test is the CI gate, as CONTRIBUTING.md does - #552

Merged
Ark0N merged 1 commit into
Ark0N:masterfrom
JDProfresh:docs/wiki-contributing-npm-test
Oct 9, 2026
Merged

Ark0N merged 1 commit into
Ark0N:masterfrom
JDProfresh:docs/wiki-contributing-npm-test

Conversation

@JDProfresh

Copy link
Copy Markdown

The wiki's Contributing page still says "Never run bare npm test" and points at test:ci. That predates 947ff6f6, which made npm test the CI gate and gave the browser, mobile and perf suites their own runners. .github/CONTRIBUTING.md and CLAUDE.md already describe the current setup; this brings the wiki page in line, keeping its existing line wrapping.

The wiki's Contributing page still warned against bare npm test and pointed at test:ci, from before 947ff6f made npm test the CI gate and gave the browser, mobile and perf suites their own runners. It now matches .github/CONTRIBUTING.md and CLAUDE.md.
@Ark0N
Ark0N merged commit 2c066eb into Ark0N:master Oct 9, 2026
2 checks passed
Ark0N pushed a commit that referenced this pull request Oct 9, 2026
Thirteen contributor PRs, each re-checked against its GitHub head, merged
with its own merge commit and landing fixes, reviewed, and gated together
(524 test files, 10194 tests): #559, #552, #550, #556, #551, #546, #542,
#540, #555, #543, #541, #502, #432.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Ark0N

Ark0N commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Merged in 1.40.0, thanks @JDProfresh! The wiki's Contributing page now says the same thing as CONTRIBUTING.md about npm test being the CI gate. One thing moved around it while landing: #556 added a static guard against fixed test ports, so that pass (c2340ae) also updated this page and CONTRIBUTING.md to tell contributors to bind port 0 and read boundPort.

@JDProfresh
JDProfresh deleted the docs/wiki-contributing-npm-test branch October 9, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants