Repository navigation
fix(deps): bump handlebars to >=4.7.10 (CVE-2026-106445, CVE-2026-106446) - #168
Merged
Merged
Conversation
…26-106445, CVE-2026-106446) Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
teallarson
marked this pull request as ready for review
October 21, 2026 19:11
laughnan
approved these changes
Oct 21, 2026
sdserranog
requested changes
Oct 21, 2026
sdserranog
left a comment
Contributor
There was a problem hiding this comment.
Is this still using Stainless? They had a really specific ways of merging things.
Contributor
Author
|
@sdserranog do you want to take this issue? I have no context on this repo 💀 |
Contributor
|
@teallarson I can take it 😄 |
sdserranog
approved these changes
Oct 23, 2026
sdserranog
left a comment
Contributor
There was a problem hiding this comment.
@teallarson this was good to go haha.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: ENGTOP-356
What changed and why
handlebarsis resolved in only one place: as a transitive dev dependency throughts-jest. The repo has a single package (no workspace packages) and a single lockfile (pnpm-lock.yaml). The resolved copy was 4.7.9, which is affected by CVE-2026-106445 and CVE-2026-106446.I upgraded the parent package instead of adding an override:
package.json:ts-jest^29.1.0→^29.4.15. 29.4.15 is the first ts-jest release that requireshandlebars: ^4.7.10(29.4.7–29.4.14 require^4.7.9). It was published 2026-10-15, so it clears the workspace'sminimumReleaseAge: 1440gate.pnpm-lock.yaml: regenerated withpnpm install(pnpm 10.30.1, as pinned inpackageManager). The lockfile changes are ts-jest 29.4.6 → 29.4.15 and handlebars 4.7.9 → 4.7.10, plus the new transitive versions those releases need: minimist 1.2.8 for handlebars, semver 7.8.5 for ts-jest.No new overrides were added. The existing override
handlebars@>=4.0.0 <4.7.9: '>=4.7.9'was left alone. ts-jest's^4.7.10range already excludes 4.7.9.handlebars versions per lockfile
pnpm-lock.yamlChecks run (locally, Node 22.23.3, pnpm 10.30.1)
pnpm install --frozen-lockfile: pass./scripts/lint(eslint, build,tsc, attw, publint): pass ("Types ok!", publint "All good!")./scripts/build: pass./scripts/test(jest against the Steady mock server): pass. 22/22 suites, 395/395 tests, 3/3 snapshots../scripts/format: this check fails, and the failure was already there before this change. It runsprettier --write, which reformats all ofpackage.jsonandpnpm-lock.yaml.prettier --checkfails on those two files on unmodifiedmainas well, and CI doesn't run the format script. I left that reformatting out of this PR to keep it scoped. The script made no other changes.Not addressed here:
pnpm auditstill reports 5 unrelated advisories (2 moderate, 3 high). They're out of scope for ENGTOP-356.Note
Low Risk
Dev-only test tooling and lockfile resolution changes; no runtime or application code is modified.
Reviewed by Cursor Bugbot for commit 8194634. Bugbot is set up for automated code reviews on this repo. Configure here.