Repository navigation
Conversation
|
@al-af could you check this out? Expo SDK 58 was just released. Maybe worth to checkout the migration guide https://github.com/expo/fyi/blob/main/ios-scene-lifecycle.md |
|
@al-af what do we need to do to get this merged? |
|
We’re blocked on this for our Expo SDK 58 upgrade, and we’ve verified on the stable release that two separate fixes are needed:
|
|
We are also blocked because of unsupported Expo 58 release. Can we please get this checked? |
|
Thanks for the contribution! This is fixed in v7.0.4 (the Expo config plugin now adds the open-URL and |
What changed
Fixes #706.
Expo SDK 58's scene-based AppDelegate template no longer declares the URL and user-activity overrides that the plugin searches for. Prebuild finishes with a warning and leaves out the AppsFlyer calls.
When those methods are absent from an
AppDelegate: ExpoAppDelegate, the plugin now inserts them. Each calls the existing AppsFlyer attribution facade and forwards tosuperso Expo's subscribers still receive the event. Expo'sSceneEventForwarderhandles React Native link delivery for this template.Existing handlers keep their bodies. The plugin does not add a duplicate when it finds a handler with custom formatting it cannot instrument; that case retains the manual-integration warning. Objective-C handling is unchanged.
The report used AppsFlyer 6.18.0. This PR targets current master (7.0.2) and uses its attribution facade; it is not a v6 backport.
Validation
npm run lintpasses.I have not tested cold/warm attribution delivery against an AppsFlyer account. The native build check uses SDK 58; older SDK compatibility is checked through the generated-source regression tests.
Standalone reproduction: https://github.com/1kuko3/appsflyer-expo-58-prebuild-repro