Repository navigation
fix(tls): serve HTTP/2 directly and normalize response headers - #20
Merged
Merged
Conversation
HTTP/2 requires lowercase header field names. uvscope set mixed-case Cache-Control, X-Frame-Options and similar response headers; libuvcpp's h2 response builder rejected the header block and dropped the stream, so browsers hung after a successful h2 handshake. Lowercase every response header, lowercase custom HTTP-probe request header names, and keep the built-in TLS listener on HTTP/2 with an HTTP/1.1 fallback. - add scripts/tls-smoke.sh (HTTP/2, ALPN h2, HTTP/1.1 fallback) - run it in Linux CI and the release pipeline - document that HTTP/3 is not yet served by the libuvcpp webapp: h3 works below the webapp, but the webapp's response path is TCP-bound and drops h3 responses. Use an h3-capable edge (nginx 1.25+/Cloudflare) or the HTTP/3 probe client until the upstream path is fixed. Verified: build, self-check, full smoke suite and tls-smoke; direct TLS HTTP/2 on a libuvcpp 1.8.8 server build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the direct TLS hang: libuvcpp's HTTP/2 response builder rejects uppercase header names, and uvscope set
Cache-Control,X-Frame-Options,Content-Security-Policy, etc. in mixed case. The h2 stream was dropped after a successful ALPN h2 handshake, so browsers waited forever.Changes
scripts/tls-smoke.sh, which starts a self-signed TLS daemon and asserts HTTP/2 200, ALPN h2 and HTTP/1.1 fallback; run it in Linux CI and the release pipeline.Verification
./scripts/build.sh--self-check0 failuresbash ./scripts/tls-smoke.sh ./build/uvscope 18830→ HTTP/2 + h1 fallbacksmoke-test.shsuite