Skip to content

test: add coverage for resolveStorePaths Windows absolute-path handling #1288

Description

@sahrizvi

Summary

#1238's Windows-path fix in packages/opencode/src/altimate/native/connections/registry.ts:128 (resolveStorePaths, using path.isAbsolute() || path.win32.isAbsolute()) is explicitly documented in its own commit message as "by-inspection only — no Windows CI." resolveStorePaths is currently unexported and has zero test references anywhere in packages/opencode/test/registry-env-loading.test.ts doesn't cover Windows paths either.

path.win32.isAbsolute() behavior is deterministic and fully testable on any OS (no Windows runner required) — this is a cheap gap to close.

Proposed fix

Export resolveStorePaths (or a thin testable wrapper) and add a unit test asserting a C:\...-style global-config path is left absolute rather than mangled by path.resolve, per the gap the #1238 commit already identified in its own message.

Provenance

Found during the v0.11.0 stable release's Tech Lead persona review.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions