Skip to content

[OGUI-1912] Fix flaky context menu tests by waiting for redraw instead of fixed delay #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaachilly merged 1 commit into from
Aug 4, 2026
Merged

[OGUI-1912] Fix flaky context menu tests by waiting for redraw instead of fixed delay #3564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions InfoLogger/test/public/context-menu-test-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,28 @@
* or submit itself to any jurisdiction.
*/

const CONTEXT_MENU_RENDER_DELAY = 25; // delay to wait for context menu to render new actions after opening

const isContextMenuOpen = async (page) => await page.evaluate(() => window.model.log.contextMenu.isOpen);

const getMenuActionLabels = async (page) => page.evaluate(() =>
Array.from(document.querySelectorAll('.cell-context-menu-item .ph2.w-100'))
.map((el) => el.textContent.trim()));

/*
* A stale menu from a previous test can already satisfy a waitForSelector check
* before the pending redraw (reflecting the new state) has actually run.
* Waiting for two animation frames guarantees the debounced redraw has fired
* at least once since the mutation.
*/
const waitForNextRender = (page) => page.evaluate(() => new Promise((resolve) => {
requestAnimationFrame(() => requestAnimationFrame(resolve));
}));

const openContextMenu = async (page, field, value, x, y) => {
await page.evaluate((field, value, x, y) => {
window.model.log.contextMenu.show(field, value, x, y);
}, field, value, x, y);
await waitForNextRender(page);
await page.waitForSelector('.cell-context-menu');
await new Promise((resolve) => setTimeout(resolve, CONTEXT_MENU_RENDER_DELAY));
};

const isMenuItemDisabled = async (page, label) => await page.evaluate((label) => {
Expand Down Expand Up @@ -53,7 +61,6 @@ const clickMenuItemByLabel = async (page, label) => {
};

module.exports = {
CONTEXT_MENU_RENDER_DELAY,
isContextMenuOpen,
getMenuActionLabels,
openContextMenu,
Expand Down