Skip to content

[PWGLF] Added Armenteros-Podolanski cut and QA histograms - #17351

Open
sawankumawat wants to merge 4 commits into
AliceO2Group:masterfrom
sawankumawat:master
Open

[PWGLF] Added Armenteros-Podolanski cut and QA histograms#17351
sawankumawat wants to merge 4 commits into
AliceO2Group:masterfrom
sawankumawat:master

Conversation

@sawankumawat

@sawankumawat sawankumawat commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
  • Added Armenteros-Podolanski cut in higherMassResonances.cxx
  • Added CosTheta* vs phi plot in higherMassResonances.cxx
  • Added generated and reconstructed true K*0 mass in MC in kstarqa.cxx

@github-actions github-actions Bot added the pwglf label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 0 disabled

@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8728a93 at 2026-08-05 19:51:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 36 errors and 202 warnings.'
Found 36 errors and 202 warnings.
++ [[ 36 -gt 0 ]]
++ cat /sw/BUILD/bbf7176296d208671ec923ed18facf6416feb61a/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/higherMassResonances.cxx:898:7: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:71:8: error: constructor does not initialize these fields: pvec0, pvec1, theta2, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:589:39: error: conversion of 'TrackFlagsRun2Enum' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:589:70: error: conversion of 'TrackFlagsRun2Enum' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:629:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:638:12: error: variable 'pt1' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:638:17: error: variable 'pt2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:638:22: error: variable 'pz1' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:638:27: error: variable 'pz2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:638:32: error: variable 'p1' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:638:36: error: variable 'p2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:638:40: error: variable 'angle' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:647:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:1125:40: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:1540:40: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:1761:42: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:1880:42: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:1906:23: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:1959:42: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2005:22: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2005:37: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2064:40: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2155:13: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2155:77: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2375:40: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2587:40: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2784:42: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2889:42: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2935:22: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2935:37: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2989:40: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:3110:101: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:3112:15: error: do not use 'else' after 'continue' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:3173:42: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:3232:23: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:3247:42: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
++ [[ 202 -gt 0 ]]
++ cat /sw/BUILD/bbf7176296d208671ec923ed18facf6416feb61a/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/higherMassResonances.cxx:503:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:506:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:508:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:516:96: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 32d2467 at 2026-08-05 20:44:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:898:28: error: 'tolerance' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 638a256 at 2026-08-05 21:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:898:28: error: 'tolerance' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft August 5, 2026 21:33
@vkucera

vkucera commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

You are supposed to check your changes before opening the PR for review.

@sawankumawat sawankumawat reopened this Aug 6, 2026
@sawankumawat
sawankumawat force-pushed the master branch 2 times, most recently from 8ba853f to 6ffa2e8 Compare August 6, 2026 05:12
@sawankumawat
sawankumawat marked this pull request as ready for review August 6, 2026 08:29
@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6ffa2e8 at 2026-08-06 11:04:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 200 warnings.'
Found 5 errors and 200 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/cd84bed8ef3561c665dc5881fe4856cb55d3181a/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarqa.cxx:71:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:666:12: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2181:13: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:2181:77: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarqa.cxx:3099:13: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 200 -gt 0 ]]
++ cat /sw/BUILD/cd84bed8ef3561c665dc5881fe4856cb55d3181a/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/higherMassResonances.cxx:504:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:507:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:509:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:517:96: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:519:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:522:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:524:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:532:100: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:534:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:545:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:547:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:550:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:552:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:563:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:584:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:587:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:589:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:597:96: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:599:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:602:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:604:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:612:100: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:614:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:625:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:627:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:630:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:632:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:657:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:707:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:740:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:898:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:900:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1024:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1048:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1269:74: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@sawankumawat
sawankumawat marked this pull request as draft August 6, 2026 10:02
@sawankumawat
sawankumawat marked this pull request as ready for review August 6, 2026 11:08
@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 698892b at 2026-08-06 14:58:

modernize-use-default-member-init
    modernize-use-designated-initializers
    modernize-use-equals-default
    modernize-use-equals-delete
    modernize-use-nodiscard
    modernize-use-nullptr
    modernize-use-override
    modernize-use-starts-ends-with
    performance-for-range-copy
    performance-implicit-conversion-in-loop
    performance-inefficient-algorithm
    performance-inefficient-string-concatenation
    performance-inefficient-vector-operation
    performance-move-const-arg
    performance-no-automatic-move
    performance-trivially-destructible
    performance-type-promotion-in-math-fn
    performance-unnecessary-copy-initialization
    performance-unnecessary-value-param
    readability-avoid-unconditional-preprocessor-if
    readability-braces-around-statements
    readability-const-return-type
    readability-container-contains
    readability-container-data-pointer
    readability-container-size-empty
    readability-delete-null-pointer
    readability-duplicate-include
    readability-else-after-return
    readability-enum-initial-value
    readability-implicit-bool-conversion
    readability-inconsistent-declaration-parameter-name
    readability-misplaced-array-index
    readability-non-const-parameter
    readability-redundant-access-specifiers
    readability-redundant-casting
    readability-redundant-control-flow
    readability-redundant-declaration
    readability-redundant-member-init
    readability-redundant-preprocessor
    readability-redundant-string-cstr
    readability-redundant-string-init
    readability-reference-to-constructed-temporary
    readability-simplify-boolean-expr
    readability-static-definition-in-anonymous-namespace
    readability-string-compare
    readability-suspicious-call-argument

++ printf '%s\n' PWGLF/Tasks/Resonances/higherMassResonances.cxx PWGLF/Tasks/Resonances/kstarqa.cxx
++ xargs -r -P 24 '-I{}' /sw/slc9_x86-64/Clang/v20.1.7-23/bin-safe/clang-tidy -p /sw/BUILD/b43ae382406c4436f66bcf63d69bb0fb4e81b7ea/O2Physics --checks= '{}'
++ tee /sw/BUILD/f7fa93bcc6d89ca19615dbb2c44d384c12fca585/O2Physics-code-check/error-log.txt

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sawankumawat @alibuild @vkucera