[PWGJE] Adding new Angularity Task to PWGJE - #17299
Draft
Rajdeep-nandi wants to merge 4 commits into
Draft
Conversation
Rajdeep-nandi
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
August 3, 2026 14:16
github-actions
Bot
changed the title
vkucera
marked this pull request as draft
August 3, 2026 14:59
Collaborator
|
@Rajdeep-nandi Please follow the contribution guidelines and make sure your PR passes the tests before you open it for review. |
nzardosh
reviewed
Aug 3, 2026
| #include "PWGJE/DataModel/Jet.h" | ||
| #include "PWGJE/DataModel/JetReducedData.h" | ||
| #include "PWGJE/DataModel/JetReducedDataHF.h" | ||
| #include "PWGJE/DataModel/JetSubstructure.h" |
Collaborator
There was a problem hiding this comment.
you seem to have alot of includes which i am not sure are needed?
Collaborator
There was a problem hiding this comment.
When you look at the output of the code-check, you will be sure. ;-)
Collaborator
There was a problem hiding this comment.
Will the code check run if I dont approve? It seems to be waiting for approval
Collaborator
There was a problem hiding this comment.
No it won't, as neither build check would. It requires your approval but also a valid PR that can be merged, which is currently not the case.
Rajdeep-nandi
added a commit
to Rajdeep-nandi/O2Physics
that referenced
this pull request
Aug 4, 2026
Please consider the following formatting changes to AliceO2Group#17299
|
O2 linter results: ❌ 1 errors, |
… issues, remove unused includes, apply clang-format
nzardosh
marked this pull request as ready for review
August 6, 2026 11:30
nzardosh
self-requested a review
August 6, 2026 11:30
nzardosh
approved these changes
Aug 6, 2026
Collaborator
|
Error while checking build/O2Physics/staging for 5a7ac58 at 2026-08-06 13:39: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 5a7ac58 at 2026-08-06 13:40: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 5a7ac58 at 2026-08-06 13:40: Full log here. |
vkucera
marked this pull request as draft
August 6, 2026 11:42
vkucera
reviewed
Aug 6, 2026
Comment on lines
+172
to
+175
| consteval float getValFromBin(int bin) | ||
| { | ||
| return static_cast<float>(bin) - 0.5f; | ||
| } |
Comment on lines
+397
to
+399
| static_cast<std::string>(eventSelections)); | ||
| trackSelection = jetderiveddatautilities::initialiseTrackSelection( | ||
| static_cast<std::string>(trackSelections)); |
Comment on lines
+498
to
+506
| const double px = trk.pt() * std::cos(trk.phi()); | ||
| const double py = trk.pt() * std::sin(trk.phi()); | ||
| const double pz = trk.pt() * std::sinh(trk.eta()); | ||
| const double p = std::sqrt(px * px + py * py + pz * pz); | ||
|
|
||
| sumPx += px; | ||
| sumPy += py; | ||
| sumPz += pz; | ||
| sumE += p; |
Collaborator
There was a problem hiding this comment.
Useless. Use existing tools.
Comment on lines
+527
to
+533
| const double p = std::sqrt(px * px + py * py + pz * pz); | ||
| const double e = std::sqrt(p * p + m * m); | ||
|
|
||
| sumPx += px; | ||
| sumPy += py; | ||
| sumPz += pz; | ||
| sumE += e; |
Collaborator
There was a problem hiding this comment.
Useless. Use existing tools.
| sumE += e; | ||
| } | ||
|
|
||
| const double m2 = sumE * sumE - (sumPx * sumPx + sumPy * sumPy + sumPz * sumPz); |
Collaborator
There was a problem hiding this comment.
Useless. Use existing tools.
Comment on lines
+607
to
+610
| TVector3 d0Vector(d0Candidate.px(), d0Candidate.py(), d0Candidate.pz()); | ||
|
|
||
| // Longitudinal momentum fraction | ||
| const float zParallel = jetVector.Dot(d0Vector) / jetVector.Dot(jetVector); |
Collaborator
There was a problem hiding this comment.
Useless. Use existing tools.
Comment on lines
+882
to
+884
| const int8_t geoStatus = static_cast<int8_t>(isGeoMatched ? 1 : 0); | ||
| const int8_t candStatus = static_cast<int8_t>(isCandMatched ? 1 : 0); | ||
| const int8_t cleanStatus = static_cast<int8_t>(isCleanMatched ? 1 : 0); |
Collaborator
There was a problem hiding this comment.
Why don't you cast the bool directly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Task calculates the Angularity for D0 particles.