[PWGUD] modify mc producer & dihadron codes - #17295
Open
miedema-11 wants to merge 6 commits into
Open
Conversation
miedema-11
commented
Aug 3, 2026
miedema-11
commented
Contributor
- an improved version for flow mc
- add event selection switch for dihadron
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Error while checking build/O2Physics/code-check for c651528 at 2026-08-04 19:05: Full log here. |
Contributor
Author
|
Hi, could you please merge the codes? Thank you very much |
Collaborator
|
@miedema-11 Why have you not fixed the errors? |
vkucera
reviewed
Aug 4, 2026
| using namespace o2::aod::rctsel; | ||
|
|
||
| #define O2_DEFINE_CONFIGURABLE(NAME, TYPE, DEFAULT, HELP) Configurable<TYPE> NAME{#NAME, DEFAULT, HELP}; | ||
| #define O2_DEFINE_CONFIGURABLE(NAME, TYPE, DEFAULT, HELP) Configurable<TYPE> NAME{#NAME, (DEFAULT), (HELP)}; // NOLINT(bugprone-macro-parentheses) |
Collaborator
There was a problem hiding this comment.
Why do you disable the error?
vkucera
reviewed
Aug 4, 2026
Comment on lines
+174
to
+177
| kITSLayersAll, | ||
| kITSLayer0123, | ||
| kITSLayer3, | ||
| kCount_ITSLayersFlag |
Collaborator
There was a problem hiding this comment.
Follow naming conventions.
vkucera
reviewed
Aug 4, 2026
| TAxis* fPtAxis = nullptr; | ||
| std::vector<GFW::CorrConfig> corrconfigsTruth; | ||
| std::vector<GFW::CorrConfig> corrconfigsReco; | ||
| TRandom3* fRndm = new TRandom3(0); |
Collaborator
There was a problem hiding this comment.
- Why do you use dynamic memory allocation?
- Where is the object destroyed?
amatyja
reviewed
Aug 4, 2026
| if (!cfgFlowAcceptance.value.empty()) { | ||
| mAcceptance = ccdb->getForTimeStamp<GFWWeights>(cfgFlowAcceptance, timestamp); | ||
| if (mAcceptance) { | ||
| LOGF(info, "Loaded acceptance weights from %s (%p)", cfgFlowAcceptance.value.c_str(), static_cast<void*>(mAcceptance)); |
Collaborator
There was a problem hiding this comment.
Hi @miedema-11, when you have LOGF with info or warning make sure it goes with a switch where you may disable this kind of outputs. Outputs sometimes are very heavy and can cause HY crash.
Collaborator
There was a problem hiding this comment.
Hi @miedema-11, you should implement a configurable flag. Let's call it debug. By default it should be false. When something is going wrong with your code you set it true and run the code for diagnostics. The structure is following: before each LOGF(info,...) and LOGF(warning,...) you use debud. Example:
if (debug) {
LOGF(info,...)
do other things;
}
I hope it helps
Contributor
Author
There was a problem hiding this comment.
Thank you for your suggestion, I have deleted this line since I don't need this debug. But the latest error doesn't seem to come from this. It is an error from the other file saying I have a redundant boolean, but I don't think it is redundant.
Collaborator
|
@miedema-11 The PR title does not tell me anything about which workflow or analysis is affected. |
Collaborator
Collaborator
amatyja
reviewed
Aug 4, 2026
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for db0e755 at 2026-08-05 20:55: Full log here. |
Contributor
Author
|
I have already tried to fix some errors from code checks, but I don't really understand the other one and I still hope to keep mine for readability and future modification. Thank you so much |
Collaborator
|
Error while checking build/O2Physics/code-check for 9c466ef at 2026-08-06 09:33: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.