Repository navigation
Feature/physx conversion tool - #175
Merged
Merged
Conversation
added 11 commits
December 2, 2024 10:34
FilipAlg
reviewed
Dec 6, 2024
FilipAlg
left a comment
FilipAlg
left a comment
Contributor
There was a problem hiding this comment.
Added some suggestions for using unity utilities where possible. Formatting seems to fail, you can try running dotnet format whitespace --folder . in the AGXUnity dir to replicate this, most likely due to it not running with any defines.
I've also recently added support for Unity Test Framework so it would be great if you could add some test cases to verify that everything is working properly
Contributor
Author
|
Refactor by robot. Now has tests and proper backup and undo support. Ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version of conversion tool