Skip to content

search() passes limit/candidates into SQL with no guard #22

Closed

Description

@royalpinto007

Problem

search() passes limit/candidates straight into SQL with no guard. Only the /ask body validates; evaluate.run_case and direct callers do not.

Where

vaultrag/retrieval.py (limit: int = 5, candidates: int = 50, interpolated into LIMIT).

Acceptance

Add a failing test first asserting search() with limit=0/-1 or candidates=-1 raises ValueError before SQL. Then fix.

Activity

  1. Rudra-G-23 commented on Sep 14, 2026

    @Rudra-G-23
    Contributor

    I'd like to work on this issue.

  2. github-actions commented on Sep 14, 2026

    @github-actions

    It's yours, @Rudra-G-23. Marked this as claimed.

    Take your time, and shout in this thread if you get stuck. If there's no activity for 14 days the claim is released so someone else can pick it up.

  3. Rudra-G-23 commented on Sep 16, 2026

    @Rudra-G-23
    Contributor

    PR raised #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

claimedSomeone is already working on this issuegood first issueGood for newcomershelp wantedExtra attention is needed

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions