test(go): cover explicit harness provider factory paths - #1073
santoshkumarradha merged 2 commits into
Conversation
santoshkumarradha
left a comment
There was a problem hiding this comment.
The new cases are useful, but the table currently does not drive the expected type assertion. Please use the expected value from each row so the test fails if a provider is paired with the wrong concrete type.
Performance
✓ No regressions detected |
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
|
Thanks — the current head already uses the table-driven expectation via |
santoshkumarradha
left a comment
There was a problem hiding this comment.
Thanks for updating the table to drive the concrete type assertion. The focused factory tests and Go vet pass locally.
The contributor addressed this request in b258422; superseded by the approval on the current head.
|
Huge thanks to the AgentField maintainers and reviewers for taking the time to review and merge #1073. 🙏 I really appreciate the feedback around making the factory tests assert the concrete provider types, and the chance to tighten the implementation before it landed. This was a great contribution experience — clear review feedback, focused validation, and a clean path from issue → implementation → review → merge. Looking forward to contributing more to AgentField and seeing where the project goes next. 🚀 And to future contributors reading this: keep shipping, keep the changes focused, and make the tests tell the story. |
Summary
Closes #404 (factory-test slice).
Scope
This takes only the
factory_test.goslice explicitly offered by #404; no production code changes.Validation
The tests are table-driven and assert the concrete provider type returned by
BuildProvider.