chore(deps): bump the go_modules group across 1 directory with 2 updates - #1060
Conversation
Bumps the go_modules group with 2 updates in the /control-plane directory: [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) and [google.golang.org/grpc](https://github.com/grpc/grpc-go). Updates `go.opentelemetry.io/otel/sdk` from 1.44.0 to 1.46.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.44.0...v1.46.0) Updates `google.golang.org/grpc` from 1.83.1 to 1.83.2 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.83.1...v1.83.2) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.46.0 dependency-type: direct:production dependency-group: go_modules - dependency-name: google.golang.org/grpc dependency-version: 1.83.2 dependency-type: direct:production dependency-group: go_modules ... Signed-off-by: dependabot[bot] <support@github.com>
santoshkumarradha
left a comment
There was a problem hiding this comment.
The gRPC patch looks low risk, but the OpenTelemetry update currently breaks the control-plane tracing URL contract and the required coverage job. I reproduced the focused failure locally. Please address the inline issue before merging.
…fter otel 1.46 bump OpenTelemetry 1.46 stopped appending the default trace signal path for WithEndpointURL (open-telemetry/opentelemetry-go#8538). Normalize pathless and root full HTTP endpoints to /v1/traces before constructing the exporter while preserving explicit collector paths and leaving gRPC behavior unchanged. Cover the root, trailing-slash, and custom-path cases so future dependency updates cannot silently change the request target again. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
AbirAbbas
left a comment
There was a problem hiding this comment.
Approving at 633602f: the otel 1.46 path regression Santosh caught is fixed in the tracer rather than by pinning back, with root / trailing-slash / custom-path cases pinned by tests, and coverage-summary is green at this head (full control-plane surface 87.8%, patch 100%). The gRPC and other bumps came through build/vet/test with no new diagnostics. Only thing left is clearing the earlier changes-requested review.
# Conflicts: # control-plane/go.mod # control-plane/go.sum
AbirAbbas
left a comment
There was a problem hiding this comment.
Re-approving at 52010cb after merging main (#1055 landed the same grpc/x/* pins, so go.mod/go.sum conflicted): kept the Dependabot side (otel 1.46, testify 1.12.1, protobuf 1.36.12 and their indirects), go mod tidy is a no-op on the result, and the branch differs from main only in go.mod, go.sum and the two tracer files. Full control-plane coverage surface and patch gate pass locally; coverage-summary and license/cla are green at this head. The one local failure, TestDispatchAgentRequestStopsWaitingOnceTheNodeIsDemoted, fails 10/30 on pristine main on my WSL2 box (loopback timeout instead of refusal) and 3/30 here, so it's the known host flake, not this bump.
Bumps the go_modules group with 2 updates in the /control-plane directory: go.opentelemetry.io/otel/sdk and google.golang.org/grpc.
Updates
go.opentelemetry.io/otel/sdkfrom 1.44.0 to 1.46.0Release notes
Sourced from go.opentelemetry.io/otel/sdk's releases.
... (truncated)
Changelog
Sourced from go.opentelemetry.io/otel/sdk's changelog.
... (truncated)
Commits
58db4c8Release v1.46.0 (#8858)524fc3cchore(deps): update golang.org/x/telemetry digest to 1f5465a (#8853)3b8ef6fchore(deps): update codspeedhq/action action to v5.2.1 (#8854)cfbeab5attribute: clarify xxhash test purpose (#8753)3599b59sdk/log: Add interface stability markers (#8855)08d52dcotlptracehttp: Accept quoted finite doubles in OTLP JSON (#8831)d720f5aotlplog: export dropped attribute count (#8829)80fe23bchore(deps): update module honnef.co/go/tools to v0.8.1 (#8816)5337812chore(deps): update codspeedhq/action action to v5.2.0 (#8851)2f73a3echore(deps): update module github.com/uudashr/iface to v1.5.1 (#8841)Updates
google.golang.org/grpcfrom 1.83.1 to 1.83.2Release notes
Sourced from google.golang.org/grpc's releases.
Commits
030ee8bUpdate version to 1.83.2 (#9375)8668b69cherry-pick #9365 to v1.83.x (#9366)a3e952dcherry-pick #9346 to v1.83.x and update x/net dependency (#9369)58f8fd9Change version to 1.83.2-dev (#9337)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.