Conversation
…try-log reasons Address the four non-blocking follow-ups from the Agent-Field#148 maintainer review: - Redaction now also replaces the JSON-escaped body of each scoped credential (values containing " or \) and its percent-/form-encoded URL spellings, in both ports. Exact matching missed those forms, so an echoed credential could still land in the archived retry log. - The terminal retry outcome and each attempt header flatten multi-line failure reasons, so the last physical line stays the greppable ===== outcome: ... ===== line. - Go resolves the credential scope through hitl.ScopeID (RunID, falling back to RootWorkflowID), matching where the scout stores when RunID is empty, for both harness env injection and retry-log redaction. - Retry-log run headers carry a monotonic section number so two invocations with the same run id in the same second stay distinct. Regression tests cover encoded spellings, multi-line flattening, the Go root-scope lookup, and same-second header uniqueness in both ports.
… redaction callback
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the four changes requested in the maintainer review of #148. The branch contains only these follow-ups on top of
main:%xx,+), including mixed-case percent escapes. Redaction is bounded and longest-first; a value that cannot be encoded still falls back to exact matching so diagnostics never fail the stage.===== outcome: ... =====retry-log entry now stays on one physical line.RootWorkflowIDwhenRunIDis empty, matching Python.Testing
Targeted regression tests pass for encoded redaction, multiline outcomes, credential-scope fallback, and distinct headers in both ports:
tests/test_planning_roles_schema_retry.pyunder Python 3.12, and Go-racetests forinternal/roles/planning,internal/harnessx, andinternal/hitl. Synthetic harness responses exercise planning through the persisted retry logs, and a pre-fix comparison reproduced the ASCII-JSON leak in the Go path. The full suite was not run.Limitations