Repository navigation
vml: vserf (ONNX Erf); simd: blend_i32_scalar (ONNX Where with scalar Y) - #399
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPh2Seh2WLccCksAdY
…unneeded second erfc polynomial Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPh2Seh2WLccCksAdY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPh2Seh2WLccCksAdY
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AdaWorldAPI
marked this pull request as ready for review
October 30, 2026 09:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the two ndarray functions that synergy-map R5 named for lance-graph's ONNX registry probe (H11, L18). It also adds R6 to
.claude/knowledge/synergy-map-2026-10-29.md.hpc::vml::vserf(ONNXErf)|x| < 1: the Cepheserffpolynomial.1 ≤ |x| < 4:1 − exp(−x²)/x · P(1/x²).|x| ≥ 4: exactly1.0.f64series reference). The tests cover six magnitude bands from 1e-38 to 100, both signs, and both the full 16-lane chunks and the remainder.erf(-0) = -0,±infgives±1, and NaN stays NaN.erfcpolynomial from 2.erfdoesn't need it: a disable run that dropped it stayed green, and a prototype measured the same 2 ULP worst case with one polynomial. It was removed.simd::blend_i32_scalardst[i] = mask bit i ? a[i] : b, forWhere(C, X, y)with a scalary, without filling abvector first.blend_i32with a filled vector over 131 lanes: two full words, one partial word, and stray bits past the end.blend_i32.Evidence
< 4select: special-values test red;xinstead of|x|: 2 tests red;blend_i32_scalar: red.cargo fmt --checkandcargo clippy --features std -- -D warningsare clean.The lance-graph side follows separately: register
Erfovervserf, and route a scalar-YWheretoblend_i32_scalar.Generated by Claude Code