Skip to content

contract(ogar_codebook): mirror directory concepts 0x0B06–0x0B09 - #1959

Merged
AdaWorldAPI merged 1 commit into
mainfrom
ccr-7a4f3a52-1mvica
Nov 4, 2026
Merged

contract(ogar_codebook): mirror directory concepts 0x0B06–0x0B09#1959
AdaWorldAPI merged 1 commit into
mainfrom
ccr-7a4f3a52-1mvica

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Nov 4, 2026

Copy link
Copy Markdown
Owner

What

This adds four rows to the zero-dep lance-graph-contract::ogar_codebook::CODEBOOK mirror, below email:

id concept
0x0B06 directory_user
0x0B07 directory_group
0x0B08 group_membership
0x0B09 license_assignment

It is paired with AdaWorldAPI/OGAR#370, which adds these concepts to ogar-vocab.

Merge order

lance-graph-ogar::assert_codebook_parity checks both directions against OGAR main. So the "lance-graph-ogar codebook-parity" CI step on this PR stays red until OGAR#370 merges. Merge OGAR#370 first, then this PR.

Tests

  • The lance-graph-contract lib tests named ogar_codebook pass (16), with canonical_concept_id lookups for the new rows.
  • I ran them on a copy of the crate, because this sandbox has no sibling ndarray checkout and the lance-graph workspace won't load without it.
  • I could not run lance-graph-ogar's parity test here: it needs OGAR#370 on main.

Generated by Claude Code

@claude
contract(ogar_codebook): mirror directory_user, directory_group, grou…
8adf8de 
…p_membership, license_assignment (0x0B06-0x0B09)

Paired with the OGAR ogar-vocab mint of the same four IAM-domain rows.
lance-graph-ogar's assert_codebook_parity checks the full bijection
against OGAR main, so its CI step goes green once the OGAR mint merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMM44PgMCtYoqx6XYnh
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d611b81e-bcc0-4938-8c53-2f8b99ce6ead
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review November 4, 2026 23:59
@AdaWorldAPI
AdaWorldAPI merged commit f2c9443 into main Nov 4, 2026
26 of 27 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T00:00:29.498263Z 8adf8de Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI Claude

AdaWorldAPI commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

The test job failed in lance-graph-ogar::parity::tests::mirror_is_a_faithful_copy_of_ogar_codebook, with the message contract mirror has directory_user=0x0b06 but OGAR disagrees. That is the expected merge-order failure.

The parity check compares this mirror against OGAR main. The run at 23:44 UTC came before AdaWorldAPI/OGAR#370, which adds the four concepts, merged at 23:52 UTC. No code change is needed here. With #370 now on main, I have re-run the failed job once.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdaWorldAPI @claude