Repository navigation
D-CODEGRAPH-0 gap map and slice A evidence; D-DQM M1 timing arms; dt64/xlog CI lines - #1918
Conversation
Maps the merges since revision (e) onto its open list and folds in the open list carried from 2026-09-18. Finding: the five unexecuted rulings of 2026-10-20 are untouched after 61 more commits, while about 22 plan files were added. Closed: the D-DRF lab arc, lance-graph-onnx over the ndarray 1-ULP numerics, the 64k slab, the semantic DuckDB differential, ndarray #317's corrections; Mississippi Queen rejected by measurement. Reframed: the hop exists three ways; multi-hop is the RECURSION row. Links K26-K30; questions Q7-Q9. No code changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…resh The branch was restarted from main. The #1240 post-merge commit written 2026-09-18 was never merged and sat about 500 PRs behind; its LATEST_STATE and PR_ARC entries described a long-superseded state, so it is not carried. Its one live finding (two impl Vocabulary over the same 34 recipe bytes, disagreeing on arity and codebook) is re-recorded as an ISSUES row read at current heads. Revision (f) row S12 updated to match; FRUITS regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
timing.py runs the same 38 cases as oracle.py, parity first: a case is timed only when DuckDB's encoded answer equals the committed expected value. It reports t_prepare_ns (PREPARE alone) and t_execute_ns (EXECUTE + fetchall) medians, the DuckDB version, and runs single-threaded by default to match Quack. Stdout only; cases.tsv is never written; no timing assertion. oracle.py gains load(con), a pure extraction so both scripts load the fixture one way; regenerating with DuckDB 2.0.0 leaves cases.tsv byte-identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
QUACK_DIFF_TIMED_REPS (default 0) adds median t_compile_or_bind_ns and t_execute_ns to the METRIC line; every timed rep asserts the untimed answer. The default run's METRIC lines are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
Records the read-side mask, the measured H14c byte behaviour (uniform vs clustered), the word-level handoff via RoaringBitmap::from_lsb0_bytes, and the _rowid/stable-id caveat. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…ries-71a5sw # Conflicts: # .claude/board/entries/README.md
…ries-71a5sw # Conflicts: # .claude/board/FRUITS.md # .claude/board/ISSUES.md # .claude/board/entries/README.md
Both crates are workspace members whose tests no workflow ran; a member's tests are not run by cargo build --workspace. Local run: dt64 36 passed, xlog 24 passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…on intake
Gap map G1-G9 from Charon to a resident Codegraph (Kythe facts + R2IL +
DT64/DR, route Charon -> ruff -> lance-graph + crai-rs): no Charon intake in
ruff, no Kythe producer in Rust, no ref/call edges, no Rust-body -> R2IL
lowering, no resident store, closure capped at 64 per tile, body anchor open,
ruff sink unmerged.
sag-ra-probe:
- pin unicode-properties =0.1.4: a fresh resolution paired Unicode 17
unicode-ident (pinned by ra_ap_hir_def) with Unicode 18 unicode-properties
and ra-ap-rustc_lexer refused to compile;
- GRAPH=1 (NO_MIR, FILES): typed rust-analyzer rows (file, node, occ with
use/pubuse roles, call, impl, import, macro, diag) as the independent
oracle for the intake;
- fixtures/codegraph/{rev1,rev2}: aliases, re-exports, trait dispatch, cfg,
macro-hidden references, unresolved names, a module cycle, a deleted
symbol.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…ad Kythe pins Kythe /xrefs 22/22 symbols, 19/19 pins (disable run fails the moved pin); Charon join 11/11, impls 5/5, CALLS 3 / MAY_DISPATCH 2 / MAY_PANIC 4. Charon witnesses the call inside assert_eq! that rust-analyzer's call hierarchy misses; rust-analyzer records a reference inside #[cfg(any())] code that the build does not contain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…n them ident_chain and the sag_fixture Kythe check reproduce exactly; the mask-risc Charon join reproduces except one body (derived PartialEq::eq now joins EXACT instead of DERIVED, same item). Contract crate not rerun: 441 MB of LLBC for 459 bodies already strains the Python join. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…nd-read pins kythe_calls_check.py serves Charon-derived entries through Kythe and checks hand-read call pins (3/3 on the codegraph fixture, 0/3 without file nodes). Board: calls byte-identical to llbc_calls.py on the fixture and mask-risc, receipt conserved, impl callees distinct across crates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0f81a2a8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _, refs, _ = query_xrefs(base, args.corpus, callee) | ||
| hit = (rel, start, end) in refs |
There was a problem hiding this comment.
Require call-edge kinds when checking call pins
If the producer emits ordinary /kythe/edge/ref edges at the pinned spans instead of /kythe/edge/ref/call, this checker still reports every pin as passing. query_xrefs requests ALL_REFERENCES and reduces the returned anchors to spans without retaining their edge kinds, so membership in refs does not establish that a call edge exists. Returning ordinary reference anchors at the three committed pin spans reproduces three successful checks. Filter for call-edge kinds before matching pins and add a negative case that replaces call edges with ordinary references, so the validation actually detects loss of the call semantics.
Useful? React with 👍 / 👎.
PR_ARC entry, LATEST_STATE block, D-CODEGRAPH-0-A shipped. Hygiene only: generates no arc entry of its own (CLAUDE.md termination clause). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
D-CODEGRAPH-0: a resident Codegraph, Charon → ruff → lance-graph + crai-rs
Plan:
.claude/plans/d-codegraph-0-resident-codegraph-v1.md. Entry:.claude/board/entries/2026-11-02-d-codegraph-0-gap-map.md. Representation: Kythe semantic facts + R2IL executable semantics + DT64/DR binding.Gap map G1–G9, checked against
mainof lance-graph, OGAR and ruff and the last 50 PRs of lance-graph and OGAR:ref/calledges;sag-ra-probe(lab crate, excluded from the workspace):ra_ap_hir_defpinsunicode-ident =1.0.24(Unicode 17) whileunicode-properties0.1.5 is Unicode 18, andra-ap-rustc_lexerrefuses the mismatch. Fixed by pinningunicode-properties = "=0.1.4".GRAPH=1mode (withNO_MIR,FILES): typed rust-analyzer rows (file,node,occwithuse/pubuseroles,call,impl,import,macro,diag), as the independent check for the Charon intake.fixtures/codegraph/{rev1,rev2}: aliases, re-exports, trait dispatch,cfg, a call hidden in a macro, unresolved names, a module cycle, a deleted symbol.rev1_xrefs.pin.tsv(19) andrev1_calls.pin.tsv(3).tools/kythe_calls_check.py: serves Charon-derived Kythe entries and checks the call pins.Measured here:
/xrefson the fixture: 22/22 symbols, 19/19 pins; a pin moved by one column fails.sag_fixtureKythe check reproduce exactly. Themask-riscCharon join reproduces except one body (a derivedPartialEq::eqnow joins EXACT instead of DERIVED; same item).assert_eq!, which rust-analyzer's call hierarchy misses.#[cfg(any())]code that the build does not contain.ruff_charon(ruff, see below):llbc_calls.pyon the fixture and onmask-risc(459 functions, 441 MB LLBC, 5.6 s release);Also on this branch (earlier in the session, never in a PR)
lance-graph-quack/tests/duckdb/timing.py);with_row_addr_prefilter).ISS-RECIPE-LOCO-VOCABULARY-EXISTS-TWICEentry, replacing a stale Wave 0 for the Cypher→mask lowering: 37.3 % of the corpus lowers fully, 0 % fails to lower, and the binding it needs already ships unconsumed #1240 update.rust-test.ymlnow runslance-graph-dt64andlance-graph-xlog, workspace members whose tests no workflow ran.Not in this PR
crates/ruff_charon: tests on the fixture's LLBC againstllbc_calls.py's output, and four disable runs each red in exactly its own test. Its PR on AdaWorldAPI/ruff is pending: the designated branch predates ruff's upstream replay (fix: remove 359 binary files from git (49 MB → 1.2 MB tracked) #121), so it shares no history with ruffmain.Validation
test_tools.py15/15,test_kythe_entries.py9/9.entries_index.py --check,append_only_gate.py origin/main, andsupersession_index.pyregenerated.sag-ra-probebuilds withcargo build --release.Generated by Claude Code