Repository navigation
lance-graph-xlog: XLOG behaviour lens 0xFFFF::0xF100 (D-XLOG-NATIVE-8) - #1913
Merged
Merged
Conversation
functor/3, arg/3 and =../2 are behaviour, not data: they get positions in XLOG's own lens (plan D-DT64-7, O7), with XLOG's helper-relation names as aliases. declare() binds each word's column count as the store's arity; the readers of that field and what a column count means to each are documented on declare. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
November 1, 2026 04:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XLOG's term built-ins (
functor/3,arg/3,=../2) are behaviour, not data. They are now addressed in XLOG's own lens0xFFFF :: 0xF100(plan D-DT64-7, decision O7). Its relational core keeps using the sharedF000algebra and gets no word here.lance_graph_xlog::lens:XLOG_LENS,XLOG_WORDS(3 positions),position_of/word_of, anddeclare.__xlog_meta_functor,_arg,_univ).__xlog_meta_failis not a word. It is an empty relation, and as empty data it already means "never true".Side effect, documented on
declare: it passes each word's column count asBindStore::declare_algebra'sarity; forF000that field is a stack operand count. Readers:BindStore::insert(dt64): aMethodBindingeffect on an XLOG word must carrycolumnsarguments.lance-graph-r2il::bindingrefuses the lens asNotR2ilReadingbefore it readsarity.No other crate reads the field.
Tests:
tests/lens.rs(3), covering the range, alias selection and non-words, and declared counts with idempotence and immutability.lance-graph-xlogsuite green; clippy-D warningsclean.The consumer half (
xlog-cuberouting these aliases toRefusal::Behaviourinstead of interning them) follows in AdaWorldAPI/xlog#2.Generated by Claude Code