Conversation
fust
requested review from
Buzzglo,
TebogoTS,
ampie,
k0da and
kuritka
as code owners
August 13, 2026 14:42
k0da
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CreatePTRis enabled, an A record update would fail if the corresponding PTR record had been deleted or never existed in Infoblox, causing a reconciliation loop with no recovery. This change detects that scenario and creates the missing PTR instead of trying to update a non-existent record.Additionally,
notFounderrors from Infoblox were previously silently swallowed inrecordSet, incrementing the failed API call counter and making it impossible to distinguish a missing record from a real error in logs or metrics.Errors are now wrapped with contextual record info before the
notFoundcheck, sonotFoundis treated as an expected condition (no counter bump, no early return) while other errors are still surfaced.A minor metric label bug ("GetObject" on the create path) and action error logging in submitChanges are also fixed.