Conversation
fust
requested review from
Buzzglo,
TebogoTS,
ampie,
k0da and
kuritka
as code owners
August 13, 2026 14:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
nameRegexis configured together with aview, the provider was still fetching all zones and issuing separate record queries per zone and per record type, resulting inN zones × M record typesAPI calls on every sync.Since
nameRegexcausesExtendedRequestBuilderto add aname~filter to every query anyway, zone-scoping becomes redundant: the same filtering can be achieved with a single global query per record type.This PR adds
useGlobalForwardRecordQueries()(true when bothnameRegexandvieware set) and skips zone fetching entirely for forward records in that case, reducing API calls fromN×MtoM.Zone fetching is still performed when PTR record creation is enabled, since PTR records must be queried per reverse zone.