feat(sync): add --scope user for store sync - #304
Closed
RaviTharuma wants to merge 2 commits into
Closed
RaviTharuma wants to merge 2 commits into
RaviTharuma wants to merge 2 commits into
Conversation
Keep the default project-scoped relay. An explicit --scope user replicates every local project's eligible observations through a separate user-global namespace, still without copying the live SQLite file. Privacy filters continue to drop personal, agent-targeted, candidate, and ephemeral rows. Fixes #302
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Device identity lives on the shared data directory. rotate no longer requires a bound Git project, matching --scope user. Namespace overrides reject path-like values.
Contributor
Author
|
Follow-up on this PR after a self-review (CI was already green; no maintainer review comments yet). Fixed in b6f18d5
Default |
Owner
|
Superseded and included in the merged 1.9.5 release PR #305, with additional scope-aware tombstone, ID remap, and namespace hardening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memorix sync storestays project-scoped by default. This adds an explicit--scope userso one local SQLite can replicate every project's eligible observations across a user's machines, without copying the live database.--scope projectis unchanged: other-project rows stay local.--scope useruses a separateuser-globalremote namespace (override withMEMORIX_SYNC_USER_NAMESPACEwhen several operators share one remote).--scope userdoes not require a Git checkout; it opens the shared data directory directly.fs|github|s3|postgres.Fixes #302
Verification
npm run lintpassed.tests/sync/engine.test.ts,tests/sync/policy.test.ts,tests/sync/sqlite-store.test.ts,tests/sync/merge.test.ts— 36 passed.Notes
User-global state is isolated from project-scoped
sync_row_state/ outbox / cursors so a row can be relayed independently in each namespace.