Skip to content

chore(fileops): route ShowDirectory OS dispatch through ISystemEnvironment #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ANcpLua merged 1 commit into from
May 14, 2026
Merged

chore(fileops): route ShowDirectory OS dispatch through ISystemEnvironment #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CreatePdf.NET/Internal/FileOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,13 @@ public static void Open(string path)
[ExcludeFromCodeCoverage(Justification = "Interacts with OS shell")]
public static void ShowDirectory(string path)
{
var environment = RuntimeSystemEnvironment.Instance;

@gemini-code-assist gemini-code-assist Bot May 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To fully adhere to the ISystemEnvironment abstraction and ensure the method depends only on the interface's contract, consider explicitly typing the environment variable as ISystemEnvironment. Using var here infers the concrete RuntimeSystemEnvironment type, which couples the logic to the implementation rather than the abstraction. Additionally, although this method is currently excluded from code coverage, depending on the interface rather than the singleton property would facilitate easier unit testing of the OS-selection logic in the future if the dependency were to be injected.

        ISystemEnvironment environment = RuntimeSystemEnvironment.Instance;

try
{
var (fileName, arguments) = true switch
{
_ when OperatingSystem.IsWindows() => ("explorer", $"/select,\"{path}\""),
_ when OperatingSystem.IsMacOS() => ("open", $"-R \"{path}\""),
_ when environment.IsWindows => ("explorer", $"/select,\"{path}\""),
_ when environment.IsMacOS => ("open", $"-R \"{path}\""),
_ => ("xdg-open", $"\"{Path.GetDirectoryName(path) ?? path}\"")
};

Expand Down
Loading