src_compressible_stag: restore the full OU state in TurbForcingComp::setU - #280
Merged
isriva merged 1 commit intoSep 22, 2026
Merged
Conversation
…setU
setU assigned only ForcingS/ForcingC. The OU update reads ForcingSold/
ForcingCold, which define() had zeroed, so on the first post-restart update the
restored amplitudes were discarded and the process restarted from a pure-noise
draw around zero:
ForcingS[i] = ForcingSold[i] - forcing_a*ForcingSold[i]*dt + ...
A restarted forced-turbulence run therefore did not continue the forcing
trajectory; the forcing needed O(1/forcing_a) of simulated time to recover its
steady amplitude, so restart was not transparent and statistics gathered right
after one were biased low.
ForcingSold == ForcingS is the invariant the update maintains, so restoring all
four arrays is sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setU assigned only ForcingS/ForcingC. The OU update reads ForcingSold/
ForcingCold, which define() had zeroed, so on the first post-restart update the
restored amplitudes were discarded and the process restarted from a pure-noise
draw around zero:
A restarted forced-turbulence run therefore did not continue the forcing
trajectory; the forcing needed O(1/forcing_a) of simulated time to recover its
steady amplitude, so restart was not transparent and statistics gathered right
after one were biased low.
ForcingSold == ForcingS is the invariant the update maintains, so restoring all
four arrays is sufficient.